Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Logging level defaults to info #18657

Merged
merged 3 commits into from
May 25, 2020

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented May 20, 2020

What does this PR do?

Changes default log level to info

Why is it important?

To save CPU cycles with default configuration. when using default beats are a bit chatty which makes monitoring filebeat resource heavy on CPU

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Fixes: #18351

@michalpristas michalpristas self-assigned this May 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 20, 2020
@michalpristas michalpristas changed the title [Ingest Manage] Logging level defaults to info [Ingest Manager] Logging level defaults to info May 20, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 20, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 3265
Skipped 486
Total 3751

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user Michal Pristas, Replayed #4]

  • Start Time: 2020-05-21T11:22:46.473+0000

  • Duration: 73 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 3265
Skipped 486
Total 3751

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ruflin
Copy link
Contributor

ruflin commented May 25, 2020

Is there a manual way to set it to debug?

@ph I think we need in ingest-manager a way to change this config option

@michalpristas
Copy link
Contributor Author

it's configurable at start we would need to create some kind of wrapper over logger which will reinstantiate it to enable log level change, as for now loggers we use does not allow on the fly level change.

@michalpristas michalpristas merged commit 74476a2 into elastic:master May 25, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request May 25, 2020
[Ingest Manager] Logging level defaults to info (elastic#18657)
michalpristas added a commit to michalpristas/beats that referenced this pull request May 25, 2020
[Ingest Manager] Logging level defaults to info (elastic#18657)
michalpristas added a commit to michalpristas/beats that referenced this pull request May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingest Management:beta1 Group issues for ingest management beta1 review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elastic Agent: default docker setup spins the CPU
5 participants