Remove vendor folder from the repository #18655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
added
[zube]: In Progress
Team:Services
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
removed
the
needs_team
|
Is there any recovery plan if the original source code of a dependency is removed? I mean, the author decides to remove the entire repository? Isn't it a too big risk? |
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
|
@mtojek It is indeed a big risk. That is why we are going to use Artifactory to mirror these packages. Adopting Artifactory is the second task from the todo list. I am rewording it to avoid confusion around the reason why we need it. |
kvch
force-pushed
the
refactoring-libbeat-remove-vendor-folder
branch
from
729f91d to
445b035
Compare
kvch
force-pushed
the
refactoring-libbeat-remove-vendor-folder
branch
2 times, most recently
from
68b026a to
6c96cd4
Compare
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
kvch
force-pushed
the
refactoring-libbeat-remove-vendor-folder
branch
from
6c96cd4 to
484a407
Compare
botelastic
bot
added
the
Team:Automation
kvch
force-pushed
the
refactoring-libbeat-remove-vendor-folder
branch
from
484a407 to
b6475c4
Compare
|
jenkins run tests |
kvch
force-pushed
the
refactoring-libbeat-remove-vendor-folder
branch
2 times, most recently
from
f2c1438 to
3c11eb0
Compare
6 tasks
kvch
force-pushed
the
refactoring-libbeat-remove-vendor-folder
branch
3 times, most recently
from
1b8983b to
612dbdf
Compare
kvch
force-pushed
the
refactoring-libbeat-remove-vendor-folder
branch
5 times, most recently
from
0ec883c to
132362b
Compare
|
Our policy requires us only to add the contents of the NOTICE files of each third party dependency. We do not have to add any additional stuff. The only reason we might do is to have information about our dependencies at that point in time. |
|
I've rebased the branch and addressed the docs issues. |
👍 Thanks for clarification. |
urso
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
PR is quite big, which makes it a little difficult to see all changes.
Looks like vendor has been removed correctly in every go command and NOTICE file is generated. All in all LGTM
Most important are NOTICE file and green CI. Please make sure to have a green CI before merging.
Please have this reviewed by at least another Person.
|
run beats-ci/package |
jsoriano
reviewed
Jun 25, 2020
kvch
force-pushed
the
refactoring-libbeat-remove-vendor-folder
branch
from
d520585 to
58c06ee
Compare
|
run beats-ci/package |
jsoriano
approved these changes
Jun 25, 2020
|
/packaging |
kvch
force-pushed
the
refactoring-libbeat-remove-vendor-folder
branch
from
58c06ee to
7bff601
Compare
|
/packaging |
kvch
force-pushed
the
refactoring-libbeat-remove-vendor-folder
branch
from
7bff601 to
921859f
Compare
|
/packaging |
|
jenkins run tests |
|
jenkins run tests please |
|
/packaging |
2 tasks
10 tasks
kvch
added a commit
to kvch/beats
that referenced
this pull request
Jun 29, 2020
To update or add a dependency use the standard tools provided by Golang. (cherry picked from commit 5426df0)
jorgelbg
added a commit
to jorgelbg/beats
that referenced
this pull request
Jul 21, 2020
PR elastic#18655 removed the vendor folder.
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
To update or add a dependency use the standard tools provided by Golang.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the vendor folder from the repository.
go.elastic.co/go-licence-detectorto generate NOTICE file- [ ] use package proxy/mirror when running CI jobs and also to use it locally if neededthe generated Beats use vendor folder, but users are free to move away from it
By removing the folder we become vulnerable to new dangers:
To combat these we are adopting Artifactory and mirroring these modules to our own infra. Before we merge this PR we need to make sure we are prepared to mitigate these issues. So a working Artifactory mirror is a must-have beforehand.We decided to merge this without Artifactory. APM team had no issues with building their binaries consistently without an own package mirror, so we are positive this decision won't have a big impact on our builds.
To update dependencies, use the standard tools provided by Golang:
Why is it important?
We need to remove dependencies, as we are not allowed to vendor every dependency we use.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.