Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18389 to 7.x: Remove unused flag in Checkpoint module configuration #18573

Merged
merged 1 commit into from
May 15, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented May 15, 2020

Cherry-pick of PR #18389 to 7.x branch. Original message:

What does this PR do?

This removes references to var.log_level in checkpoint module's configuration. This variable is not used, just a left-over from using the cisco module as a base.

Why is it important?

Avoid confusing users with a configuration option that does nothing and references docs from a different vendor.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

This removes references to `var.log_level` in checkpoint module's
configuration. This variable is not used, just a left-over from using
the cisco module as a base.

(cherry picked from commit e742954)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 15, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 15, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user Adrian Serrano, Replayed I can't install packetbeat #1]

  • Start Time: 2020-05-15T12:46:02.968+0000

  • Duration: 49 min 31 sec (2910864)

Test stats 🧪

Test Results
Failed 0
Passed 1185
Skipped 128
Total 1313

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov
    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Result: FAILURE

    • Duration: 2 min 22 sec

    • Start Time: 2020-05-15T13:31:46.860+0000

    • log

@adriansr adriansr merged commit 65baa4a into elastic:7.x May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants