Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Fix logging read from runnings process #18275

Merged
merged 2 commits into from
May 6, 2020

Conversation

ph
Copy link
Contributor

@ph ph commented May 6, 2020

Since running process are using the debug level by default now, we have
a log of messages going through the log.

This commit add multiline support reading.

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Since running process are using the debug level by default now, we have
a log of messages going through the log.

This commit add multiline support reading.
@ph ph added review needs_backport PR is waiting to be backported to other branches. [zube]: In Review elastic-agent Ingest Management:alpha1 Group issues for ingest management alpha1 labels May 6, 2020
@ph ph requested review from ruflin and michalpristas May 6, 2020 00:54
@ph ph self-assigned this May 6, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 6, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 6, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

@andresrc andresrc removed the needs_team Indicates that the issue/PR needs a Team:* label label May 6, 2020
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, change tested locally with suggested change,
image

x-pack/elastic-agent/pkg/agent/operation/monitoring.go Outdated Show resolved Hide resolved
ruflin added a commit to ruflin/beats that referenced this pull request May 6, 2020
@ruflin
Copy link
Contributor

ruflin commented May 6, 2020

Opened a backport here to get this green in time: #18285

@michalpristas michalpristas merged commit 1d67ba4 into elastic:master May 6, 2020
ruflin added a commit that referenced this pull request May 6, 2020
@ph
Copy link
Contributor Author

ph commented May 6, 2020

thanks both of you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingest Management:alpha1 Group issues for ingest management alpha1 needs_backport PR is waiting to be backported to other branches. review [zube]: In Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants