Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18003 to 7.x: Do not require unnecessary configuration #18185

Merged
merged 1 commit into from
May 4, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #18003 to 7.x branch. Original message:

What does this PR do?

This PR is based on #17960 and waiting for it to go in.

At the moment when we omit download, retry, process or management.mode section in config agent will panic and die.
This PR allows these section to be empty (skipped) and the only thing needed are configuration of what the user wants to monitor (output and sources)

Why is it important?

To ease up using of standalone agent and not requiring configuration options user does not even understand.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Fixes: #17883

* log paths within data

* changelog

* removed file

* empty config allowed

* configuration up to date and unified

* changelog

* unified

* switched path

* unnecessary type specifier

* logs-output

* var run to data path

* inject run so meta.json is not created at root of data
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Project:fleet)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 4, 2020
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

@michalpristas michalpristas merged commit f49fc73 into elastic:7.x May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport enhancement Ingest Management:alpha1 Group issues for ingest management alpha1 needs_team Indicates that the issue/PR needs a Team:* label review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants