Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Add dashboard for googlecloud storage metricset #18172

Merged
merged 7 commits into from
May 5, 2020
Merged

[Metricbeat] Add dashboard for googlecloud storage metricset #18172

merged 7 commits into from
May 5, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented May 4, 2020

What does this PR do?

This PR is to add dashboard for googlecloud storage metricset.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  1. Make sure your GCP account for testing has storage buckets
  2. Enable googlecloud module: ./metricbeat modules enable googlecloud
  3. Edit modules.d/googlecloud.yml to:
- module: googlecloud
  metricsets:
    - storage
  project_id: "your project id"
  credentials_file_path: "your JSON credentials file path"
  exclude_labels: false
  period: 5m
  1. Start metricbeat: ./metricbeat -e
  2. Wait for 5 minutes and you should see data points in GCP storage dashboard.

Screenshots

metricbeat-googlecloud-storage-overview2

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 4, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this May 4, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 4, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 3020
Skipped 756
Total 3776

@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review May 5, 2020 00:22
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. review Team:Platforms Label for the Integrations - Platforms team test-plan Add this PR to be manual test plan labels May 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@andresrc andresrc removed the needs_team Indicates that the issue/PR needs a Team:* label label May 5, 2020
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kaiyan-sheng kaiyan-sheng merged commit 8935545 into elastic:master May 5, 2020
@kaiyan-sheng kaiyan-sheng deleted the dashboard_gcp branch May 5, 2020 17:02
@kaiyan-sheng kaiyan-sheng added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels May 5, 2020
kaiyan-sheng added a commit that referenced this pull request May 5, 2020
…#18257)

* add dashboard for googlecloud storage

(cherry picked from commit 8935545)
@andresrc andresrc added the test-plan-added This PR has been added to the test plan label May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Platforms Label for the Integrations - Platforms team test-plan Add this PR to be manual test plan test-plan-added This PR has been added to the test plan v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants