Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #17906 to 7.x: [Metricbeat GCP] Improve integration test to generate more specific data-*.json #18011

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Apr 27, 2020

Cherry-pick of PR #17906 to 7.x branch. Original message:

What does this PR do?

This PR is to improve TestData in integration test for each metricset under googlecloud module to generate more than one data.json file.

Why is it important?

This improves visibility on what events look like for different metric types. For example, in compute metricset, you can see different events like data_cpu.json, data_disk.json, data_firewall.json and data_network.json. Every time, code changes are made in stackdriver metricset, these data_*.json files should be regenerated to make sure they still look correct as expected.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

…ata-*.json (#17906)

* Improve TestData integration test to generate more specific data-*.json

* rerun TestData to generate data.json files

(cherry picked from commit 3bba66d)
@kaiyan-sheng kaiyan-sheng self-assigned this Apr 27, 2020
@kaiyan-sheng kaiyan-sheng added the Team:Platforms Label for the Integrations - Platforms team label Apr 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@kaiyan-sheng kaiyan-sheng merged commit 3ba2d22 into elastic:7.x Apr 27, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_17906_7.x branch April 27, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport review Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants