Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review dependency patterns in Jenkins #18004

Merged
merged 5 commits into from
Apr 28, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Apr 27, 2020

What does this PR do?

Make some changes in the obtention of dependency patterns in Jenkins:

  • Take into account the dependencies of generators go code, make it depend on Metricbeat beater too.
  • Don't look for dependencies of libbeat for all beats. These dependencies are already included in the patterns of any other beat as transitive dependencies (all beats depend on libbeat).
  • Run go list directly on the host instead of inside a docker container.

Why is it important?

  • Fix dependency checking for generators.
  • Speed-up collection of dependency patterns, that is executed in all builds. It is reduced from more than 3 minutes to about 30 seconds.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@jsoriano jsoriano force-pushed the jenkins-vendor-patterns-docker branch from 0b738e3 to de5b270 Compare April 27, 2020 12:35
@jsoriano jsoriano self-assigned this Apr 27, 2020
@jsoriano jsoriano force-pushed the jenkins-vendor-patterns-docker branch from 27139af to e3b5f91 Compare April 27, 2020 16:55
@jsoriano jsoriano added [zube]: In Review review Team:Platforms Label for the Integrations - Platforms team labels Apr 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@jsoriano jsoriano marked this pull request as ready for review April 27, 2020 18:23
@jsoriano jsoriano requested a review from kuisathaverat April 27, 2020 18:23
@jsoriano jsoriano added Team:Integrations Label for the Integrations team and removed Team:Platforms Label for the Integrations - Platforms team labels Apr 27, 2020
@jsoriano jsoriano merged commit f24f744 into elastic:master Apr 28, 2020
@jsoriano jsoriano deleted the jenkins-vendor-patterns-docker branch April 28, 2020 08:45
jsoriano added a commit to jsoriano/beats that referenced this pull request Apr 28, 2020
Fix dependency checking for generators, looking now for dependencies
of the generators code itself (beatgen) and Metricbeat beater.
Stop looking for dependencies of libbeat in all beats, this is redundant
as they are already transitive dependencies.
Run collection of dependecies in the host instead of using docker, what
is slightly faster.
jsoriano added a commit that referenced this pull request Apr 28, 2020
Backport some features added to Jenkinsfile to 7.x branch:
* Dry run option.
* Docker login.
* Git config for generator tests.
* Filter changes using go list.

These are the cherry-picked changes:
* fix: login into the docker registry (#17620)
* feat: filter changes using go list output (#17397)
* fix: disable workaround on macos (#17750)
* ci: set git user configuration if it is not set (#17782)
* fix: mount Docker credentials (#17798)
* Review dependency patterns collection in Jenkins (#18004)

Co-authored-by: Ivan Fernandez Calvo <[email protected]>
Co-authored-by: Victor Martinez <[email protected]>
Co-authored-by: Andrew Kroh <[email protected]>
v1v added a commit to v1v/beats that referenced this pull request Apr 28, 2020
…unbld

* upstream/master:
  ci: comment PRs with the build status (elastic#17971)
  Add domain state metricset to kvm module (elastic#17673)
  [Agent] Allow CLI paths override (elastic#17781)
  Fix generated metricbeat so create-metricset works. (elastic#18020)
  LIBBEAT: Enhancement replace_string processor for replacing strings values of fields. (elastic#17342)
  Update stale references to _xpack to refer to _license instead (elastic#18030)
  Review dependency patterns collection in Jenkins (elastic#18004)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants