Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corrected module decode_cef documentation from Beta to GA #17944

Merged
merged 4 commits into from
May 4, 2020
Merged

corrected module decode_cef documentation from Beta to GA #17944

merged 4 commits into from
May 4, 2020

Conversation

111andre111
Copy link
Contributor

What does this PR do?

decode_cef codec is not beta any more.
For the moment this is not consistent with https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-module-cef.html

Why is it important?

https://www.elastic.co/guide/en/beats/filebeat/current/processor-decode-cef.html and https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-module-cef.html have differences regarding documentation. This should be fixed after this PR is merged.

@111andre111
Copy link
Contributor Author

For the moment I don't see how the backport works.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@elasticmachine
Copy link
Collaborator

💔 Build Failed

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-04-30T20:36:08.027+0000

  • Duration: 89 min 29 sec (5369149)

  • Commit: 8cabc33

Test stats 🧪

Test Results
Failed 1
Passed 509
Skipped 7
Total 517

Test errors

Expand to view the tests failures

  • Name: runTest – nose.failure.Failure

    • Status: FAILED
    • Age: 1
    • Duration: 0
    • Error Details: Cannot subscript an existing Union. Use Union[u, t] instead.

Steps errors

Expand to view the steps failures

  • Name: Mage update build test

    • Description: mage update build test

    • Result: FAILURE

    • Duration: 6 min 5 sec<

    • Start Time: 2020-04-30T21:58:55.257+0000

Log output

Expand to view the last 100 lines of log output 

[2020-04-30T22:05:00.022Z]   File "/var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17944/python-env/build/ve/linux/lib/python3.5/site-packages/nose/importer.py", line 47, in importFromPath
[2020-04-30T22:05:00.022Z]     return self.importFromDir(dir_path, fqname)
[2020-04-30T22:05:00.022Z]   File "/var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17944/python-env/build/ve/linux/lib/python3.5/site-packages/nose/importer.py", line 94, in importFromDir
[2020-04-30T22:05:00.022Z]     mod = load_module(part_fqname, fh, filename, desc)
[2020-04-30T22:05:00.022Z]   File "/usr/lib/python3.5/imp.py", line 234, in load_module
[2020-04-30T22:05:00.022Z]     return load_source(name, filename, file)
[2020-04-30T22:05:00.022Z]   File "/usr/lib/python3.5/imp.py", line 172, in load_source
[2020-04-30T22:05:00.022Z]     module = _load(spec)
[2020-04-30T22:05:00.022Z]   File "<frozen importlib._bootstrap>", line 693, in _load
[2020-04-30T22:05:00.022Z]   File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
[2020-04-30T22:05:00.022Z]   File "<frozen importlib._bootstrap_external>", line 665, in exec_module
[2020-04-30T22:05:00.022Z]   File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
[2020-04-30T22:05:00.022Z]   File "/var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17944/src/github.com/elastic/beats/x-pack/filebeat/tests/system/test_xpack_modules.py", line 6, in <module>
[2020-04-30T22:05:00.022Z]     import test_modules
[2020-04-30T22:05:00.022Z]   File "/var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17944/src/github.com/elastic/beats/x-pack/filebeat/tests/system/../../../../filebeat/tests/system/test_modules.py", line 12, in <module>
[2020-04-30T22:05:00.022Z]     from deepdiff import DeepDiff
[2020-04-30T22:05:00.022Z]   File "/var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17944/python-env/build/ve/linux/lib/python3.5/site-packages/deepdiff/__init__.py", line 10, in <module>
[2020-04-30T22:05:00.022Z]     from .diff import DeepDiff
[2020-04-30T22:05:00.022Z]   File "/var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17944/python-env/build/ve/linux/lib/python3.5/site-packages/deepdiff/diff.py", line 17, in <module>
[2020-04-30T22:05:00.022Z]     from ordered_set import OrderedSet
[2020-04-30T22:05:00.022Z]   File "/var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17944/python-env/build/ve/linux/lib/python3.5/site-packages/ordered_set.py", line 51, in <module>
[2020-04-30T22:05:00.022Z]     class OrderedSet(MutableSet[T], Sequence[T]):
[2020-04-30T22:05:00.022Z]   File "/var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17944/python-env/build/ve/linux/lib/python3.5/site-packages/ordered_set.py", line 186, in OrderedSet
[2020-04-30T22:05:00.022Z]     def update(self, sequence: SetLike[T]) -> int:
[2020-04-30T22:05:00.022Z]   File "/usr/lib/python3.5/typing.py", line 546, in __getitem__
[2020-04-30T22:05:00.022Z]     "Cannot subscript an existing Union. Use Union[u, t] instead.")
[2020-04-30T22:05:00.022Z] TypeError: Cannot subscript an existing Union. Use Union[u, t] instead.
[2020-04-30T22:05:00.022Z] 
[2020-04-30T22:05:00.022Z] [error] 100.00% nose.failure.Failure.runTest: 0.0049s
[2020-04-30T22:05:00.022Z] ----------------------------------------------------------------------
[2020-04-30T22:05:00.022Z] Ran 1 test in 0.006s
[2020-04-30T22:05:00.022Z] 
[2020-04-30T22:05:00.022Z] FAILED (errors=1)
[2020-04-30T22:05:00.022Z] >> python test: Unit Testing Complete
[2020-04-30T22:05:00.022Z] Error: running "/var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17944/python-env/build/ve/linux/bin/nosetests --process-timeout=90 --with-timer --with-xunit --xunit-file=build/TEST-python-unit.xml tests/system/test_xpack_modules.py" failed with exit code 1
[2020-04-30T22:05:00.384Z] Recording test results
[2020-04-30T22:05:07.237Z] Stashed 2 file(s)
[2020-04-30T22:05:07.279Z] Archiving artifacts
[2020-04-30T22:05:08.839Z] + curl -sSLo codecov https://codecov.io/bash
[2020-04-30T22:05:08.872Z] + FILE=auditbeat/build/coverage/full.cov
[2020-04-30T22:05:08.872Z] + [ -f auditbeat/build/coverage/full.cov ]
[2020-04-30T22:05:08.872Z] + FILE=filebeat/build/coverage/full.cov
[2020-04-30T22:05:08.872Z] + [ -f filebeat/build/coverage/full.cov ]
[2020-04-30T22:05:08.872Z] + FILE=heartbeat/build/coverage/full.cov
[2020-04-30T22:05:08.872Z] + [ -f heartbeat/build/coverage/full.cov ]
[2020-04-30T22:05:08.872Z] + FILE=libbeat/build/coverage/full.cov
[2020-04-30T22:05:08.872Z] + [ -f libbeat/build/coverage/full.cov ]
[2020-04-30T22:05:08.872Z] + FILE=metricbeat/build/coverage/full.cov
[2020-04-30T22:05:08.872Z] + [ -f metricbeat/build/coverage/full.cov ]
[2020-04-30T22:05:08.872Z] + FILE=packetbeat/build/coverage/full.cov
[2020-04-30T22:05:08.872Z] + [ -f packetbeat/build/coverage/full.cov ]
[2020-04-30T22:05:08.872Z] + FILE=winlogbeat/build/coverage/full.cov
[2020-04-30T22:05:08.872Z] + [ -f winlogbeat/build/coverage/full.cov ]
[2020-04-30T22:05:08.872Z] + FILE=journalbeat/build/coverage/full.cov
[2020-04-30T22:05:08.872Z] + [ -f journalbeat/build/coverage/full.cov ]
[2020-04-30T22:05:11.173Z] Failed in branch Filebeat x-pack
[2020-04-30T22:05:11.410Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17944/src/github.com/elastic/beats
[2020-04-30T22:05:11.843Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-04-30T22:05:11.880Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17944/src/github.com/elastic/beats/Lint
[2020-04-30T22:05:12.194Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17944/src/github.com/elastic/beats/Filebeat-x-pack
[2020-04-30T22:05:12.847Z] + cat
[2020-04-30T22:05:12.848Z] + /usr/local/bin/runbld ./runbld-script
[2020-04-30T22:05:12.848Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-04-30T22:05:19.971Z] runbld>>> runbld started
[2020-04-30T22:05:19.971Z] runbld>>> 1.6.11/a66728ff8f4356963772e6e6d2069392fa06acbe
[2020-04-30T22:05:21.066Z] runbld>>> The following profiles matched the job 'Beats/beats-beats-mbp/PR-17944' in order of occurrence in the config (last value wins).
[2020-04-30T22:05:22.105Z] runbld>>> Debug logging enabled.
[2020-04-30T22:05:22.105Z] runbld>>> Storing result
[2020-04-30T22:05:22.395Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-04-30T22:05:22.395Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200430220522-A6E3ADBA
[2020-04-30T22:05:22.395Z] runbld>>> Adding system facts.
[2020-04-30T22:05:23.518Z] runbld>>> Adding vcs info for the latest commit:  33d792a519b714d146b0601bfd1c5a1b212614da
[2020-04-30T22:05:23.518Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-04-30T22:05:23.518Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-04-30T22:05:23.518Z] Processing JUnit reports with runbld...
[2020-04-30T22:05:23.518Z] + echo 'Processing JUnit reports with runbld...'
[2020-04-30T22:05:24.176Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-04-30T22:05:24.176Z] runbld>>> DURATION: 17ms
[2020-04-30T22:05:24.176Z] runbld>>> STDOUT: 40 bytes
[2020-04-30T22:05:24.176Z] runbld>>> STDERR: 49 bytes
[2020-04-30T22:05:24.176Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-04-30T22:05:24.176Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17944/src/github.com/elastic/beats
[2020-04-30T22:05:25.308Z] runbld>>> Storing build metadata: 
[2020-04-30T22:05:25.308Z] runbld>>> Adding test report.
[2020-04-30T22:05:25.308Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17944/src/github.com/elastic/beats
[2020-04-30T22:05:26.415Z] runbld>>> Found 2 test output files
[2020-04-30T22:05:26.720Z] runbld>>> Test output logs contained: Errors: 1 Failures: 0 Tests: 517 Skipped: 0
[2020-04-30T22:05:27.048Z] runbld>>> Storing result
[2020-04-30T22:05:27.048Z] runbld>>> FAILURES: 1
[2020-04-30T22:05:27.435Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-04-30T22:05:27.435Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200430220522-A6E3ADBA
[2020-04-30T22:05:27.435Z] runbld>>> Email notification disabled by environment variable.
[2020-04-30T22:05:27.435Z] runbld>>> Slack notification disabled by environment variable.
[2020-04-30T22:05:35.138Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17944
[2020-04-30T22:05:35.660Z] [INFO] getVaultSecret: Getting secrets
[2020-04-30T22:05:35.841Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-04-30T22:05:37.496Z] + chmod 755 generate-build-data.sh
[2020-04-30T22:05:37.496Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-17944/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-17944/runs/7 FAILURE 5369149
[2020-04-30T22:05:38.047Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-17944/runs/7/steps/?limit=10000 -o steps-info.json
[2020-04-30T22:05:39.390Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-17944/runs/7/tests/?status=FAILED -o tests-errors.json

@andrewkroh andrewkroh merged commit 2e4c7c3 into elastic:master May 4, 2020
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels May 4, 2020
@andrewkroh andrewkroh mentioned this pull request May 4, 2020
Merged
@andrewkroh andrewkroh mentioned this pull request May 4, 2020
Merged
andrewkroh pushed a commit to andrewkroh/beats that referenced this pull request May 4, 2020
@111andre111 @andrewkroh
Mark decode_cef as GA in documentation (elastic#17944)
39d7500 
decode_syslog is no longer in beta. It is used by the cef module which is not beta.

Co-authored-by: Andrew Kroh <[email protected]>
(cherry picked from commit 2e4c7c3)
andrewkroh pushed a commit to andrewkroh/beats that referenced this pull request May 4, 2020
@111andre111 @andrewkroh
Mark decode_cef as GA in documentation (elastic#17944)
9786167 
decode_syslog is no longer in beta. It is used by the cef module which is not beta.

Co-authored-by: Andrew Kroh <[email protected]>
(cherry picked from commit 2e4c7c3)
andrewkroh added a commit that referenced this pull request May 5, 2020
@andrewkroh @111andre111
Mark decode_cef as GA in documentation (#17944) (#18175)
87fe454 
decode_syslog is no longer in beta. It is used by the cef module which is not beta.

Co-authored-by: Andrew Kroh <[email protected]>
(cherry picked from commit 2e4c7c3)

Co-authored-by: André Letterer <[email protected]>
andrewkroh added a commit that referenced this pull request May 12, 2020
@andrewkroh @111andre111
Mark decode_cef as GA in documentation (#17944) (#18176)
d369c45 
decode_syslog is no longer in beta. It is used by the cef module which is not beta.

Co-authored-by: Andrew Kroh <[email protected]>
(cherry picked from commit 2e4c7c3)

Co-authored-by: André Letterer <[email protected]>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@andrewkroh @111andre111
Mark decode_cef as GA in documentation (elastic#17944) (elastic#18176)
f620607 
decode_syslog is no longer in beta. It is used by the cef module which is not beta.

Co-authored-by: Andrew Kroh <[email protected]>
(cherry picked from commit b65a342)

Co-authored-by: André Letterer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@dedemorton dedemorton Awaiting requested review from dedemorton

@jamiehynds jamiehynds Awaiting requested review from jamiehynds

Assignees
No one assigned
Labels
docs module v7.7.0 v7.8.0 [zube]: Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@111andre111 @elasticmachine @andrewkroh @andresrc