-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Elatic Agent] Enable debug level logging for Metricbeat and Filebeat for Alpha #17935
[Elatic Agent] Enable debug level logging for Metricbeat and Filebeat for Alpha #17935
Conversation
Pinging @elastic/ingest-management (Team:Ingest Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Any concerns around creating too much log data in FB / MB? I remember we have some defaults there.
This will create a lot of logs, I am going to do a followup I will still merge this so this unblock other teams. |
d8bbec3
to
a28d2a2
Compare
rebased on master and pushed it again.. This should fix the jenkins issues with GVM, I presume.. since we didn't change anything. . that could trigger that problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems ok for me but we need to start plan for this to be configurable. afaik debug is not part of any reloadables, this means it cannot be configured via grpc config change. requires work on beats side.
@michalpristas Can you create a beats issue for reloadable logging configuration? It might already exist. |
a28d2a2
to
64826d5
Compare
rebased because lint failed on filebeat.. ? |
💚 Build SucceededExpand to view the summary
Build stats
|
… for Alpha (elastic#17935) * Enable debug level logging for Metricbeat and Filebeat for Alpha * Changelog
… for Alpha (elastic#17935) * Enable debug level logging for Metricbeat and Filebeat for Alpha * Changelog
… for Alpha (#17935) (#18305) * Enable debug level logging for Metricbeat and Filebeat for Alpha * Changelog Co-authored-by: Pier-Hugues Pellerin <[email protected]>
… for Alpha (#17935) (#18307) * Enable debug level logging for Metricbeat and Filebeat for Alpha * Changelog Co-authored-by: Pier-Hugues Pellerin <[email protected]>
… for Alpha (elastic#17935) (elastic#18307) * Enable debug level logging for Metricbeat and Filebeat for Alpha * Changelog Co-authored-by: Pier-Hugues Pellerin <[email protected]>
What does this PR do?
Enable debug level logging for Metricbeat and Filebeat for Alpha
Why is it important?
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs