[docs] Adds list of type changes to the 7.0 breaking changes docs #17911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedemorton
added
docs
needs_backport
|
Pinging @elastic/integrations (Team:Integrations) |
|
Thanks @dedemorton. I haven't been following the changes in Beats closely after the lead up to 7.0, nor am I familiar with the field changes that happened before 7.0 that were unrelated to ECS. But I'll be happy to review once this is ready. |
|
Unfortunately I'm not really familiar with all the changes made. I guess we will have to discuss how we can track schema changes better in the future |
|
@webmat @urso Sounds like we have two separate problems. We need to:
I'm not sure where to go from here. For 1, is there some way to reconstruct the schema changes that are not included in this PR? Is it worth the effort? Can we automate it? For 2, I wonder if @andresrc can help. |
|
Agreed, that's why I opened the initial issue. Once again, all of the ECS-related changes have been tracked, as far as I know. It's a matter of looking at what else people were doing at that time, that weren't captured. I opened that original issue because I can't do it myself. I've worked on a bunch of Filebeat modules for 3 months, once. But that's it. I don't know the code base very much. |
💚 Build Succeeded
Expand to view the summary
Build stats
|
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
|
This PR is stalled. Should I close it? |
|
I'm afraid so, sorry for this, let's try to get it better for 8.0 |
dedemorton
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds list of type changes requested in #11790.
#11790 has been open for a very long time. I was hoping the dev team would take ownership because the list of changed types is incomplete.
For the sake of getting what we know into the published docs, I'm opening this PR. I think, however, that this kind of documentation should be generated or at last maintained by the dev team when they make changes to field types or names.
@webmat Including you as a reviewer because you opened the original issue.
@urso Adding you to the review so we have a plan going forward to make sure this doesn't happen again.