Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where application ID of cloudfoundry.access events is incorrect. #17847

Merged
merged 3 commits into from
Apr 21, 2020

Conversation

blakerouse
Copy link
Contributor

What does this PR do?

Fixes issue where the cloudfoundry event for cloudfoundry.access event types was creating the cloudfoundry.app.id in the memory format of the UUID instead of the required string formatted.

Wrong: low:3046190763798940950 high:12644936126740546741
Correct: 4ef05e5d-d2a6-4c58-9229-d112587b74dd

Why is it important?

The format must use the correct string so the add_cloudfoundry_metadata processor can get the application data from CloudFoundry. This is also causing stress on the cloudfoundry API as it will keep checking for applications that are invalid and cause 404's.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@blakerouse blakerouse added the Team:Platforms Label for the Integrations - Platforms team label Apr 20, 2020
@blakerouse blakerouse requested a review from a team April 20, 2020 20:42
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@blakerouse blakerouse force-pushed the fix-cloudfoundry-access-uuid branch from cd5ad50 to a511f47 Compare April 20, 2020 20:44
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! could you add some unit tests?

@blakerouse
Copy link
Contributor Author

@exekias I have added unit tests to cover all the event types.

@blakerouse blakerouse added the bug label Apr 21, 2020
@exekias exekias added the needs_backport PR is waiting to be backported to other branches. label Apr 21, 2020
mahak pushed a commit to mahak/beats that referenced this pull request Apr 21, 2020
…rect. (elastic#17847)

* Fix issue where application ID of cloudfoundry.access events is incorrect.

* Add changelog entry.

* Add unit tests for cloudfoundry events.
@blakerouse blakerouse merged commit c388f5e into elastic:master Apr 21, 2020
@blakerouse blakerouse deleted the fix-cloudfoundry-access-uuid branch April 21, 2020 16:50
@blakerouse blakerouse restored the fix-cloudfoundry-access-uuid branch April 21, 2020 16:55
@blakerouse blakerouse added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 21, 2020
blakerouse added a commit to blakerouse/beats that referenced this pull request Apr 21, 2020
…rect. (elastic#17847)

* Fix issue where application ID of cloudfoundry.access events is incorrect.

* Add changelog entry.

* Add unit tests for cloudfoundry events.

(cherry picked from commit 08e1b2b)
blakerouse added a commit to blakerouse/beats that referenced this pull request Apr 21, 2020
…rect. (elastic#17847)

* Fix issue where application ID of cloudfoundry.access events is incorrect.

* Add changelog entry.

* Add unit tests for cloudfoundry events.

(cherry picked from commit 08e1b2b)
@blakerouse blakerouse deleted the fix-cloudfoundry-access-uuid branch April 21, 2020 17:00
blakerouse added a commit that referenced this pull request Apr 21, 2020
…rect. (#17847) (#17876)

* Fix issue where application ID of cloudfoundry.access events is incorrect.

* Add changelog entry.

* Add unit tests for cloudfoundry events.

(cherry picked from commit 08e1b2b)
blakerouse added a commit that referenced this pull request Apr 21, 2020
…rect. (#17847) (#17878)

* Fix issue where application ID of cloudfoundry.access events is incorrect.

* Add changelog entry.

* Add unit tests for cloudfoundry events.

(cherry picked from commit 08e1b2b)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…rect. (elastic#17847) (elastic#17878)

* Fix issue where application ID of cloudfoundry.access events is incorrect.

* Add changelog entry.

* Add unit tests for cloudfoundry events.

(cherry picked from commit 66343d9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Platforms Label for the Integrations - Platforms team v7.7.0 v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants