Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Agent] Rename the User-Agent string from Beats Agent to Elastic Agent #17765

Merged
merged 3 commits into from
Apr 17, 2020

Conversation

ph
Copy link
Contributor

@ph ph commented Apr 16, 2020

When we changed the name of the agent to Elastic Agent we forgot to
update the User-Agent string send on every request.

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
When we changed the name of the agent to Elastic Agent we forgot to
update the User-Agent string send on every request.
@ph ph added review needs_backport PR is waiting to be backported to other branches. [zube]: In Review Team:Ingest Management labels Apr 16, 2020
@ph ph requested a review from michalpristas April 16, 2020 17:51
@ph ph self-assigned this Apr 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@ph ph changed the title Rename the User-Agent string from Beats Agent to Elastic Agent [Agent] Rename the User-Agent string from Beats Agent to Elastic Agent Apr 16, 2020
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see mac workers are still weird

@ph ph merged commit d826dee into elastic:master Apr 17, 2020
ph added a commit to ph/beats that referenced this pull request Apr 17, 2020
elastic#17765)

* Rename the User-Agent string from Beats Agent to Elastic Agent

When we changed the name of the agent to Elastic Agent we forgot to
update the User-Agent string send on every request.

(cherry picked from commit d826dee)
@ph ph added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 17, 2020
ph added a commit that referenced this pull request Apr 20, 2020
#17765) (#17802)

* Rename the User-Agent string from Beats Agent to Elastic Agent

When we changed the name of the agent to Elastic Agent we forgot to
update the User-Agent string send on every request.

(cherry picked from commit d826dee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants