Fix setup.dashboards.index not working #17749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriansr
commented
Apr 16, 2020
| } | ||
|
|
||
| objects, ok := content["objects"].([]interface{}) |
There was a problem hiding this comment.
This was not a []interface{}, causing it to silently fail.
|
Thank you for fixing this @adriansr!! Any chance you can add a test? |
|
jenkins, test this |
adriansr
force-pushed
the
fix_setup_dashboards_index
branch
from
526aadc to
1e4c88b
Compare
|
Pinging @elastic/integrations (Team:Integrations) |
adriansr
force-pushed
the
fix_setup_dashboards_index
branch
2 times, most recently
from
3bb4477 to
a8723ec
Compare
Due to type casting nightmare, the setting of `setup.dashboards.index` configuration option to replace the index name in use for dashboards and index pattern wasn't being honored.
adriansr
force-pushed
the
fix_setup_dashboards_index
branch
from
a8723ec to
e3642de
Compare
exekias
approved these changes
Apr 22, 2020
exekias
added
the
needs_backport
|
The CI seems to be pretty brittle lately, but none of the failures can be attributed to this change, so I'll go ahead and merge |
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Apr 23, 2020
Due to type casting nightmare, the setting of `setup.dashboards.index` configuration option to replace the index name in use for dashboards and index pattern wasn't being honored. Fixes elastic#14019 (cherry picked from commit 07d0c8c)
adriansr
removed
the
needs_backport
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Apr 23, 2020
Due to type casting nightmare, the setting of `setup.dashboards.index` configuration option to replace the index name in use for dashboards and index pattern wasn't being honored. Fixes elastic#14019 (cherry picked from commit 07d0c8c)
adriansr
added a commit
that referenced
this pull request
Apr 24, 2020
adriansr
added a commit
that referenced
this pull request
Apr 24, 2020
|
I can't seem to get this working in 7.10 without doing a find and replace in the dashboard json files. |
|
I am having the same issue. This setting seems completely ignored when running |
|
This is the PR that addressed this in 7.7 and 7.8. |
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Due to type casting nightmare, the setting of `setup.dashboards.index` configuration option to replace the index name in use for dashboards and index pattern wasn't being honored. Fixes elastic#14019 (cherry picked from commit 5000780)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to type casting nightmare, the
setup.dashboards.indexconfiguration option to replace the index name in use for dashboards and index pattern wasn't being honored, resulting inbeatname-*always in use.Fixes: #14019