Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests of urldecode processor parallelized #17601

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Make tests of urldecode processor parallelized #17601

merged 1 commit into from
Apr 8, 2020

Conversation

sincejune
Copy link
Contributor

@sincejune sincejune commented Apr 8, 2020 •
edited by andresrc
Loading

What does this PR do?

Make tests of urldecode processor parallelized.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@sincejune sincejune changed the title enable urldecode parallelizing test Make tests of urldecode processor parallelized Apr 8, 2020
@jsoriano jsoriano added :Testing [zube]: In Review review Team:Services (Deprecated) Label for the former Integrations-Services team labels Apr 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

ycombinator
ycombinator approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ycombinator
Copy link
Contributor

run tests

@ycombinator ycombinator added needs_backport PR is waiting to be backported to other branches. v7.8.0 v8.0.0 and removed review labels Apr 8, 2020
@ycombinator
Copy link
Contributor

CI failures are unrelated. Merging.

@ycombinator ycombinator merged commit 757ebb6 into elastic:master Apr 8, 2020
@ycombinator
Copy link
Contributor

Waiting on #17589 to be merged before backporting this PR to 7.x.

syepes pushed a commit to syepes/beats that referenced this pull request Apr 9, 2020
@sincejune @syepes
enable urldecode parallelizing test (elastic#17601)
1c1ec3e
@ycombinator ycombinator mentioned this pull request Apr 13, 2020
Merged
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Apr 13, 2020
ycombinator added a commit that referenced this pull request Apr 14, 2020
@ycombinator @sincejune
enable urldecode parallelizing test (#17601) (#17691)
63cad40 
Co-authored-by: Chao <[email protected]>
@sincejune sincejune deleted the enable-urldecode-parallelizing-test branch April 17, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees
No one assigned
Labels
Team:Services (Deprecated) Label for the former Integrations-Services team :Testing v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sincejune @elasticmachine @ycombinator @jsoriano @andresrc