Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vsphere VM dashboard show VM host aggregation works #17555

Merged
merged 2 commits into from
Apr 7, 2020

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Apr 7, 2020

What does this PR do?

Fixes issue where 2 of the visualizations in the "VMs overview ECS" dashboard where not using the correct field, preventing the visualization to work.

Why is it important?

Fixes issue so vsphere dashboard works correctly.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse blakerouse added bug Team:Platforms Label for the Integrations - Platforms team labels Apr 7, 2020
@blakerouse blakerouse requested a review from a team April 7, 2020 01:52
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I guess we should backport this? (I think it affects all versions since 7.5.0 #7213).

@jsoriano jsoriano added needs_backport PR is waiting to be backported to other branches. v7.6.3 v7.7.0 v7.8.0 labels Apr 7, 2020
@blakerouse blakerouse merged commit 4a3c555 into elastic:master Apr 7, 2020
@blakerouse blakerouse deleted the fix-vsphere-dashboard branch April 7, 2020 13:04
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Apr 7, 2020
@blakerouse blakerouse removed the needs_backport PR is waiting to be backported to other branches. label Apr 7, 2020
blakerouse added a commit to blakerouse/beats that referenced this pull request Apr 7, 2020
* Fix vsphere dashboard.

* Add changelog entry.

(cherry picked from commit 4a3c555)
blakerouse added a commit to blakerouse/beats that referenced this pull request Apr 7, 2020
* Fix vsphere dashboard.

* Add changelog entry.

(cherry picked from commit 4a3c555)
@blakerouse
Copy link
Contributor Author

@jsoriano 7.6 doesn't seem to have the metricbeat-vsphere-vm.json file.

@blakerouse blakerouse removed the v7.6.3 label Apr 7, 2020
blakerouse added a commit that referenced this pull request Apr 7, 2020
)

* Fix vsphere dashboard.

* Add changelog entry.

(cherry picked from commit 4a3c555)
blakerouse added a commit that referenced this pull request Apr 7, 2020
)

* Fix vsphere dashboard.

* Add changelog entry.

(cherry picked from commit 4a3c555)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
… (elastic#17576)

* Fix vsphere dashboard.

* Add changelog entry.

(cherry picked from commit 9239185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Platforms Label for the Integrations - Platforms team v7.7.0 v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSphere module dashboard does not load 2 of the visualizations
4 participants