Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in args #17544

Closed
wants to merge 1 commit into from
Closed

Fix typo in args #17544

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 6, 2020

Bug; Typo in Args

What does this PR do?

This PR adds the missing in comma in the args array.

Why is it important?

Invalid Args array without it, broken manifest on master

Checklist

  • [/ ] My code follows the style guidelines of this project
  • [ /] I have commented my code, particularly in hard-to-understand areas
  • [ /] I have made corresponding changes to the documentation
  • [ /] I have made corresponding change to the default configuration files
  • [ /] I have added tests that prove my fix is effective or that my feature works
  • [X ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Logs

k apply -f ./auditbeat-kubernetes.yaml configmap/auditbeat-config configured configmap/auditbeat-daemonset-modules unchanged error: error parsing ./auditbeat-kubernetes.yaml: error converting YAML to JSON: yaml: line 26: did not find expected ',' or ']'

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
bc044bd

Please, read and sign the above mentioned agreement if you want to contribute to this project

@andresrc andresrc added Team:Platforms Label for the Integrations - Platforms team Team:SIEM labels Apr 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@@ -23,7 +23,7 @@ spec:
- name: auditbeat
image: docker.elastic.co/beats/auditbeat:%VERSION%
args: [
"-c", "/etc/auditbeat.yml"
"-c", "/etc/auditbeat.yml",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update

"-c", "/etc/auditbeat.yml"

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think #17595 fixed this typo already.

@andresrc
Copy link
Contributor

Yes, fixed in #17595 . Thanks for the contribution!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants