[Agent] Expose stream.* data in every event #17468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ingest-management (Project:fleet) |
michalpristas
commented
Apr 3, 2020
|
@hbharding It is an error that you are assigned to this PR? |
ph
approved these changes
Apr 7, 2020
There was a problem hiding this comment.
Small comment concerning the document block of a function otherwise, LGTM Good workd @michalpristas
| @@ -429,6 +436,117 @@ func InjectIndex(indexType string) *InjectIndexRule { | |||
| } | |||
| } | |||
|
|
|||
| // InjectStreamProcessorRule expect target to be a collection of fields including | |||
| // _meta_index map with dataset, index and namespace keys defined. | |||
There was a problem hiding this comment.
I think this comment need to be changed since we do not have the _meta_index present in the code?
ph
approved these changes
Apr 14, 2020
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Apr 15, 2020
[Agent] Expose stream.* data in every event (elastic#17468) (cherry picked from commit 70fba87)
6 tasks
michalpristas
added a commit
that referenced
this pull request
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR generates a processor for each input exposing stream.[namespace/type/dataset] values to each event.
Why is it important?
Some modules define like Suricata a single input where mixed events are generated: metrics, logs or alerts. The identification of the data is often done in the ingest pipeline, where the type is generated from fields or values from the data.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Fixes: #16562