Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command which installs mage #17388

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Apr 1, 2020

What does this PR do?

This PR fixes the install command of mage. With the adoption of go modules adding /... has become necessary in order to install the pacakge.

Why is it important?

This issue prevents beats from installing mage if it is not present. One of the symptoms of this problem is the failure to generate new Beats if mage is not available.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kvch kvch added needs_backport PR is waiting to be backported to other branches. [zube]: In Review Team:Services (Deprecated) Label for the former Integrations-Services team labels Apr 1, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kvch kvch merged commit 18eb496 into elastic:master Apr 1, 2020
kvch added a commit to kvch/beats that referenced this pull request Apr 2, 2020
This PR fixes the install command of `mage`. With the adoption of go modules adding `/...` has become necessary in order to install the pacakge.

This issue prevents beats from installing `mage` if it is not present. One of the symptoms of this problem is the failure to generate new Beats if `mage` is not available.

(cherry picked from commit 18eb496)
@kvch kvch added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 2, 2020
kvch added a commit to kvch/beats that referenced this pull request Apr 2, 2020
This PR fixes the install command of `mage`. With the adoption of go modules adding `/...` has become necessary in order to install the pacakge.

This issue prevents beats from installing `mage` if it is not present. One of the symptoms of this problem is the failure to generate new Beats if `mage` is not available.

(cherry picked from commit 18eb496)
@kvch kvch added the v7.7.0 label Apr 2, 2020
kvch added a commit that referenced this pull request Apr 3, 2020
This PR fixes the install command of `mage`. With the adoption of go modules adding `/...` has become necessary in order to install the pacakge.

This issue prevents beats from installing `mage` if it is not present. One of the symptoms of this problem is the failure to generate new Beats if `mage` is not available.

(cherry picked from commit 18eb496)
kvch added a commit that referenced this pull request Apr 3, 2020
This PR fixes the install command of `mage`. With the adoption of go modules adding `/...` has become necessary in order to install the pacakge.

This issue prevents beats from installing `mage` if it is not present. One of the symptoms of this problem is the failure to generate new Beats if `mage` is not available.

(cherry picked from commit 18eb496)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
This PR fixes the install command of `mage`. With the adoption of go modules adding `/...` has become necessary in order to install the pacakge.

This issue prevents beats from installing `mage` if it is not present. One of the symptoms of this problem is the failure to generate new Beats if `mage` is not available.

(cherry picked from commit 54cdadd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Services (Deprecated) Label for the former Integrations-Services team v7.7.0 v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants