Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Improve ECS categorization field mappings for mssql module #17376

Merged
merged 3 commits into from
Apr 1, 2020

Conversation

leehinman
Copy link
Contributor

What does this PR do?

Adds ECS categorization fields to mssql module. Specifically:

  • event.kind
  • event.category
  • eventy.type

and converts mssql pipeline from json to yaml

Why is it important?

Adding ECS categorization fields improves usability of the data in the SIEM app and makes searches across datasets easier.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

GENERATE=true TESTING_FILEBEAT_MODULES=mssql mage -v pythonIntegTest

Related issues

Closes #16171

@leehinman leehinman added enhancement Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Team:SIEM ecs labels Mar 31, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

- event.kind
- event.category
- event.type

Closes elastic#16171
@leehinman leehinman force-pushed the 16171_mssql_ecs_1.4 branch from dfab268 to 020fe5e Compare March 31, 2020 19:36
@leehinman leehinman merged commit e3c72b3 into elastic:master Apr 1, 2020
@leehinman leehinman deleted the 16171_mssql_ecs_1.4 branch April 1, 2020 20:33
@leehinman leehinman added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 1, 2020
leehinman added a commit to leehinman/beats that referenced this pull request Apr 1, 2020
…elastic#17376)

Improve ECS categorization field mappings for mssql module.

- event.kind
- event.category
- event.type

Closes elastic#16171

(cherry picked from commit e3c72b3)
leehinman added a commit that referenced this pull request Apr 2, 2020
…#17376) (#17417)

Improve ECS categorization field mappings for mssql module.

- event.kind
- event.category
- event.type

Closes #16171

(cherry picked from commit e3c72b3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Filebeat] Upgrade mssql module to ECS 1.4
3 participants