Support Fixed length extraction #17191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
|
Hi @newly12, thank you for your contribution. In order to proceed with reviewing this PR and accepting your contribution, we first need to you to sign the Elastic Contributor License Agreement (CLA): https://www.elastic.co/contributor-agreement. Thanks! |
ycombinator
added
:Processors
libbeat
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
|
@ycombinator, I will work with our internal legal team to have @newly12 added to our corporate CLA by EOD thursday. |
|
Sounds good, thanks @vjsamuel! |
ycombinator
reviewed
Apr 29, 2020
ycombinator
reviewed
Apr 29, 2020
| @@ -30,7 +30,7 @@ an error; you need to either drop or rename the key before using dissect. | |||
| For tokenization to be successful, all keys must be found and extracted, if one of them cannot be | |||
| found an error will be logged and no modification is done on the original event. | |||
|
|
|||
| NOTE: A key can contain any characters except reserved suffix or prefix modifiers: `/`,`&`, `+` | |||
There was a problem hiding this comment.
Could you also add the # modifier to the table of modifiers further down in this same file? Also please add a section for fixed length extraction similar to sections for the other modifiers.
There was a problem hiding this comment.
@ycombinator I failed to find sections for modifier in this file, could you please point me to that? thx!
There was a problem hiding this comment.
I'm sorry, I was looking at the Elasticsearch dissect processor's documentation (https://www.elastic.co/guide/en/elasticsearch/reference/master/dissect-processor.html) when I made that comment. You're right, there is no such section in the Beat's dissect processor's documentation (https://www.elastic.co/guide/en/beats/filebeat/7.6/dissect.html). 🤦
There was a problem hiding this comment.
Thanks for the info. It is pretty good doc for dissect processor! It will be good to have similar doc in beats or a link to the modfier part..
|
Hi @newly12, thanks for this contribution! The code and tests look great; I just added a couple of comments about adding docs, etc. Also, please add an entry to the Thanks again! |
newly12
force-pushed
the
dissect_supports_fixed_length_extraction
branch
2 times, most recently
from
1cbbe63 to
1814167
Compare
|
Hi @ycombinator thanks a lot for reviewing this! I've updated |
Signed-off-by: Peter Deng <[email protected]>
newly12
force-pushed
the
dissect_supports_fixed_length_extraction
branch
from
1814167 to
1b563cc
Compare
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
ycombinator
approved these changes
Apr 30, 2020
|
CI failures are unrelated. Merging. |
ycombinator
added a commit
that referenced
this pull request
May 6, 2020
Signed-off-by: Peter Deng <[email protected]> Co-authored-by: Peter Deng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows dissect processor to do fixed-length field extraction.
Why is it important?
Before this PR dissect does not provide such ability.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesRelated issues
Fixes elastic/dissect-specification#6