Move mage debugging to script #17174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresrc
added
[zube]: Inbox
[zube]: In Progress
and removed
[zube]: Inbox
[zube]: In Progress
labels
|
if you move the call inside the https://github.com/elastic/beats/blob/master/Jenkinsfile#L533-L566 |
|
I have a PR in progress that does what @kuisathaverat suggests. It's still a draft b/c I was testing out some things, but all of the Windows builds are green and the debug dump option works in it. I plan to clean it up today and remove the draft label. #17071 |
|
@andrewkroh Sounds good. I will close this in favor of #17071 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modifies the Jenkins configuration to call a script to dump mage variables, which does better error handling in the case of mage not being present.
Why is it important?
Prevents a situation wherein mage being absent causes a test run to fail.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs