Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #16892 to 7.x: [Metricbeat] Separate vpc metricset to vpn, transitgateway and natgateway metricsets #17149

Merged
merged 2 commits into from
Mar 20, 2020
Merged

Cherry-pick #16892 to 7.x: [Metricbeat] Separate vpc metricset to vpn, transitgateway and natgateway metricsets #17149

merged 2 commits into from
Mar 20, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Mar 20, 2020 •
edited by andresrc
Loading

Cherry-pick of PR #16892 to 7.x branch. Original message:

What does this PR do?

This PR is to separate vpc metricset into three smaller metricsets: vpn, transitgateway and natgateway metricsets. This PR will also add dashboards for each metricset.

Why is it important?

This will help with users who only wants to enable one or two out of all three metricsets.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Screenshots

vpn dashboard:
Screen Shot 2020-03-18 at 12 21 41 PM (2)

nat gateway dashboard:
Screen Shot 2020-03-17 at 3 29 25 PM (2)

transit gateway dashboard:
Screen Shot 2020-03-18 at 1 39 46 PM (2)

@kaiyan-sheng
[Metricbeat] Separate vpc metricset to vpn, transitgateway and natgat…
1b59312 
…eway metricsets (#16892)

* Separate vpc metricset to vpn, transitgateway and natgateway metricsets
* add dashboard and screenshot 

(cherry picked from commit 7a7c2af)
@kaiyan-sheng kaiyan-sheng self-assigned this Mar 20, 2020
@kaiyan-sheng kaiyan-sheng added the Team:Platforms Label for the Integrations - Platforms team label Mar 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

blakerouse
blakerouse approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kaiyan-sheng kaiyan-sheng merged commit 485ab79 into elastic:7.x Mar 20, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_16892_7.x branch March 20, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
backport review Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @elasticmachine @blakerouse