Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #16244 to 7.x: New input for Office 365 audit logs #17109

Merged
merged 3 commits into from
Mar 20, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Mar 19, 2020

Cherry-pick of PR #16244 to 7.x branch. Original message:

What does this PR do?

This adds a new input, o365audit, to retrieve audit events from an Office 365 subscription using Microsoft's Office 365 Management API.

Why is it important?

This is a first step in developing a module to ingest O365 audit events.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • Add fields.yml. moved to module
  • Documentation.
  • Finish request error handling in contentblob/pagination.
  • Persist state (needs Input V2).
  • (Optional) Client secret-based authentication.

How to test this PR locally

Setup an Azure application in an existing O365 subscription. Follow the steps in this blog post: https://medium.com/@kiamatthews/office-365-management-api-connector-for-elk-b94fe4ed4a53

Related issues

@adriansr adriansr force-pushed the backport_16244_7.x branch 2 times, most recently from 81b5c3d to b24d8c1 Compare March 19, 2020 22:23
This input uses Microsoft's Office 365 Management API to fetch audit
events.

Relates to elastic#16196

(cherry picked from commit ed80900)
@adriansr adriansr force-pushed the backport_16244_7.x branch from b24d8c1 to 08bdaac Compare March 19, 2020 22:28
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriansr adriansr merged commit d35ca4f into elastic:7.x Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants