-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check ES for CCR feature availability #17073
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
cdc8a17
Add TODO
ycombinator 79e1b81
Check if CCR feature is available in ES
ycombinator 0965036
Allow tests to disable license caching
ycombinator be74b1f
Add unit tests
ycombinator 52bf9d4
Separate message
ycombinator d0570ab
Adding license header
ycombinator 13e4b24
Adding CHANGELOG entry
ycombinator ef82a63
Check enabled, not available
ycombinator c16a5e1
Renaming var
ycombinator 0ae344c
Adding documentation
ycombinator cafb9c6
Doc feedback fixes
ycombinator File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,8 @@ | ||
This is the `ccr` metricset of the Elasticsearch module. It interrogates the | ||
Cross Cluster Replication Stats API endpoint to fetch information about shards | ||
in the Elasticsearch cluster that are participating in cross-cluster replication. | ||
This is the `ccr` metricset of the {es} module. It uses the | ||
Cross-Cluster Replication Stats API endpoint to fetch metrics about cross-cluster | ||
replication from the {es} clusters that are participating in cross-cluster | ||
replication. | ||
|
||
If the {es} cluster does not have cross-cluster replication enabled, this metricset | ||
will not collect metrics. A DEBUG log message about this will be emitted in the | ||
Metricbeat log. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,116 @@ | ||
// Licensed to Elasticsearch B.V. under one or more contributor | ||
// license agreements. See the NOTICE file distributed with | ||
// this work for additional information regarding copyright | ||
// ownership. Elasticsearch B.V. licenses this file to you under | ||
// the Apache License, Version 2.0 (the "License"); you may | ||
// not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
package ccr | ||
|
||
import ( | ||
"net/http" | ||
"net/http/httptest" | ||
"strconv" | ||
"testing" | ||
|
||
"github.com/stretchr/testify/require" | ||
|
||
"github.com/elastic/beats/v7/metricbeat/module/elasticsearch" | ||
|
||
mbtest "github.com/elastic/beats/v7/metricbeat/mb/testing" | ||
) | ||
|
||
func startESServer(esVersion, license string, ccrEnabled bool) *httptest.Server { | ||
|
||
nodesLocalHandler := func(w http.ResponseWriter, r *http.Request) { | ||
w.Write([]byte(`{"nodes": { "foobar": {}}}`)) | ||
} | ||
clusterStateMasterHandler := func(w http.ResponseWriter, r *http.Request) { | ||
w.Write([]byte(`{"master_node": "foobar"}`)) | ||
} | ||
rootHandler := func(w http.ResponseWriter, r *http.Request) { | ||
if r.URL.Path != "/" { | ||
http.NotFound(w, r) | ||
} | ||
w.Write([]byte(`{"version": { "number": "` + esVersion + `" } }`)) | ||
} | ||
licenseHandler := func(w http.ResponseWriter, r *http.Request) { | ||
w.Write([]byte(`{ "license": { "type": "` + license + `" } }`)) | ||
} | ||
xpackHandler := func(w http.ResponseWriter, r *http.Request) { | ||
w.Write([]byte(`{ "features": { "ccr": { "enabled": ` + strconv.FormatBool(ccrEnabled) + `}}}`)) | ||
} | ||
ccrStatsHandler := func(w http.ResponseWriter, r *http.Request) { | ||
http.Error(w, "this should never have been called", 418) | ||
} | ||
|
||
mux := http.NewServeMux() | ||
mux.Handle("/_nodes/_local/nodes", http.HandlerFunc(nodesLocalHandler)) | ||
mux.Handle("/_cluster/state/master_node", http.HandlerFunc(clusterStateMasterHandler)) | ||
mux.Handle("/", http.HandlerFunc(rootHandler)) | ||
mux.Handle("/_license", http.HandlerFunc(licenseHandler)) // for 7.0 and above | ||
mux.Handle("/_xpack/license", http.HandlerFunc(licenseHandler)) // for before 7.0 | ||
mux.Handle("/_xpack", http.HandlerFunc(xpackHandler)) | ||
mux.Handle("/_ccr/stats", http.HandlerFunc(ccrStatsHandler)) | ||
|
||
return httptest.NewServer(mux) | ||
} | ||
|
||
func TestCCRNotAvailable(t *testing.T) { | ||
tests := map[string]struct { | ||
esVersion string | ||
license string | ||
ccrEnabled bool | ||
}{ | ||
"old_version": { | ||
"6.4.0", | ||
"platinum", | ||
true, | ||
}, | ||
"low_license": { | ||
"7.6.0", | ||
"basic", | ||
true, | ||
}, | ||
"feature_unavailable": { | ||
"7.6.0", | ||
"platinum", | ||
false, | ||
}, | ||
} | ||
|
||
// Disable license caching for these tests | ||
elasticsearch.LicenseCacheEnabled = false | ||
defer func() { elasticsearch.LicenseCacheEnabled = true }() | ||
|
||
for name, test := range tests { | ||
t.Run(name, func(t *testing.T) { | ||
server := startESServer(test.esVersion, test.license, test.ccrEnabled) | ||
defer server.Close() | ||
|
||
ms := mbtest.NewReportingMetricSetV2Error(t, getConfig(server.URL)) | ||
events, errs := mbtest.ReportingFetchV2Error(ms) | ||
|
||
require.Empty(t, errs) | ||
require.Empty(t, events) | ||
}) | ||
} | ||
} | ||
|
||
func getConfig(host string) map[string]interface{} { | ||
return map[string]interface{}{ | ||
"module": elasticsearch.ModuleName, | ||
"metricsets": []string{"ccr"}, | ||
"hosts": []string{host}, | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a sentence fragment. Maybe say something like:
"This metricset uses the Cross-Cluster Replication Stats API endpoint to fetch...."