Cherry-pick #16321 to 7.x: Add support for kubernetes provider to recognize namespace level defaults #17054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ults (elastic#16321) * Add support for kubernetes provider to recognize namespace level default hints (cherry picked from commit 004d36c)
CHANGELOG.next.asciidoc
Outdated
| @@ -201,6 +201,9 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d | |||
| - Remove experimental flag from `setup.template.append_fields` {pull}16576[16576] | |||
| - Add `add_cloudfoundry_metadata` processor to annotate events with Cloud Foundry application data. {pull}16621[16621] | |||
| - Add `translate_sid` processor on Windows for converting Windows security identifier (SID) values to names. {issue}7451[7451] {pull}16013[16013] | |||
| - Add Kerberos support to Kafka input and output. {pull}16781[16781] | |||
There was a problem hiding this comment.
ups, fixed, thanks!
kaiyan-sheng
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #16321 to 7.x branch. Original message:
This PR allows namespace level defaults to be configured on the namespace object for either service or pod hints autodiscover. This will need:
to be set on the kubernetes autodiscover provider.
This PR has a known gap where a pod is deployed before the namespace annotations are added. In this case, autodiscover wouldnt be able to add in the defaults. To fix that behavior we would need to ensure that we handle resync events as updates. Currently we ignore resync events as the resource version remains the same.