-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase HTTP client timeout in kubernetes state_deployment tests #17001
Conversation
Test data for state_deployment metricset is quite big, and the metricset may need more than the 10 seconds default timeout of HTTP clients, provoking sporadic failures in CI. Increase this timeout for this case.
Pinging @elastic/integrations-platforms (Team:Platforms) |
Why is 10 secs not enough time based on the size of the test data? Seems that 10 sec is a large amount of time for an HTTP request. |
Yeah, it should be definitely enough, we could investigate it more later. I would only like to address flakiness of this test by now. It could be about memory. Big Prometheus responses take a lot of memory in Metricbeat, recently I did some profiling with a 27MB response and it required more than 600MB in Metricbeat. The one in this test case is 12MB big, maybe in an overloaded Jenkins worker this is enough to make things slow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to fix the test for now, but yeah we should look into why it needs that much time.
…astic#17001) Test data for state_deployment metricset is quite big, and the metricset may need more than the 10 seconds default timeout of HTTP clients, provoking sporadic failures in CI. Increase this timeout for this case. (cherry picked from commit 610f996)
Test data for state_deployment metricset is quite big, and the metricset
may need more than the 10 seconds default timeout of HTTP clients,
provoking sporadic failures in CI.
Increase this timeout for this case.
This should fix flaky tests like: