Cherry-pick #16609 to 7.x: Prometheus remote write endpoint #16973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #16609 to 7.x branch. Original message:
What does this PR do?
This PR implements Prometheus remote write as a new metricset.
Why is it important?
How to test this PR locally
Start metricbeat
Sending metrics from Prometheus
Use this forked project: https://github.com/ChrsMark/dockprom.
docker-compose up
With that metrics should be collected by metricbeat and reported.
Related issues
Notes about changes
This PR changes
HttpServer
so as to accepthandlerFunc
from metricset on server initialisation. This makes it reusable from different metricsets and not onlyserver
metricset ofhttp
module. In order to confirm thatserver
metricset ofhttp
module is not broken I runINTEGRATION_TESTS=1 BEAT_STRICT_PERMS=false nosetests ./module/http/test_http.py
successfully which shows that functionality is preserved.