Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #16692 to 7.x: Fix diskio struct alignment for windows 32 bit versions #16830

Merged
merged 4 commits into from
Mar 6, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Mar 5, 2020

Cherry-pick of PR #16692 to 7.x branch. Original message:

Shoukd fix #16680.

Added disk_performance_386.go and disk_performance_amd64.go files to define the struct, chose 2 separate files to clearly separate implementation should we ever want to update / remove the support for 32 bit versions etc.

@narph narph requested a review from a team as a code owner March 5, 2020 10:23
@narph narph self-assigned this Mar 5, 2020
@narph narph added backport Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team labels Mar 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@narph narph merged commit 595e9b0 into elastic:7.x Mar 6, 2020
@narph narph deleted the backport_16692_7.x branch March 6, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants