Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Clarify how ILM affects template setup options #16704

Merged
merged 4 commits into from
Mar 4, 2020

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Feb 29, 2020

Replaces #12419 plus adds a small edit

chrousto and others added 2 commits February 28, 2020 16:40
Just added the following warning : 
Warning	If {ref}/ilm.html[Index Lifecycle Management] is enabled (which is the default), setup.template.name and setup.template.pattern won’t be taken into account.

So that users are aware that ILM, that is enabled by default from 7.0 on (https://www.elastic.co/guide/en/beats/functionbeat/current/ilm.html)

Regards,
Christophe.
@dedemorton dedemorton added docs review needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team labels Feb 29, 2020
@dedemorton
Copy link
Contributor Author

@ycombinator Ok, I've added a warning to the ILM docs, too. BTW, I think we can't way that ILM is the default because it depends on the cluster. It's only the default if you are connecting to a cluster that supports ILM. That's clarified in the ILM docs. So I added the weasel word "typically".

@dedemorton dedemorton requested a review from ycombinator March 4, 2020 20:38
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dedemorton dedemorton merged commit 3763139 into elastic:master Mar 4, 2020
@dedemorton dedemorton deleted the replace_12419 branch March 4, 2020 21:46
dedemorton added a commit to dedemorton/beats that referenced this pull request Mar 4, 2020
dedemorton added a commit to dedemorton/beats that referenced this pull request Mar 9, 2020
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Mar 9, 2020
dedemorton added a commit that referenced this pull request Mar 10, 2020
dedemorton added a commit that referenced this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants