Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #16234 to 7.x: Add database_account azure metricset #16662

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Cherry-pick #16234 to 7.x: Add database_account azure metricset #16662

merged 2 commits into from
Feb 28, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Feb 27, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #16234 to 7.x branch. Original message:

Should solve #15758

Lightweight metricset based on monitor

Config:

  - module: azure
    metricsets:
    - database_account
    enabled: true
    period: 300s
    client_id: '${AZURE_CLIENT_ID:""}'
    client_secret: '${AZURE_CLIENT_SECRET:""}'
    tenant_id: '${AZURE_TENANT_ID:""}'
    subscription_id: '${AZURE_SUBSCRIPTION_ID:""}'

extra config options as in the other metricsets:

resources:
 - resource_group: []
 - resource_id: []

The metrics in https://docs.microsoft.com/en-us/azure/azure-monitor/platform/metrics-supported#microsoftdocumentdbdatabaseaccounts should be retrieved.
The DatabaseName dimension is applied for the metrics which support it.

cc: @sorantis

narph added 2 commits February 27, 2020 11:25
@narph
Add database_account azure metricset (elastic#16234)
7888276 
* add metricset

* work on database_Account

* fix

* work on tests

* mage fmt update

* work on manifest

* update json

* move timegrain

* uppercase

(cherry picked from commit 6816bb1)
@narph
changelog
4066f29
@narph narph requested a review from a team as a code owner February 27, 2020 10:35
@narph narph self-assigned this Feb 27, 2020
@narph narph added [zube]: In Review backport Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team labels Feb 27, 2020
kaiyan-sheng
kaiyan-sheng approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@narph narph merged commit 4355341 into elastic:7.x Feb 28, 2020
@narph narph deleted the backport_16234_7.x branch February 28, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@narph narph

Labels
backport Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @kaiyan-sheng @andresrc