Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove feature.Describer and enhance Details #16658

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Remove feature.Describer and enhance Details #16658

merged 1 commit into from
Feb 27, 2020

Conversation

urso
Copy link

@urso urso commented Feb 27, 2020 •
edited by andresrc
Loading

  • Refactoring

What does this PR do?

  • Remove redundant Describer interface and handle Details as a value struct. Details will be passed by value and is not really modifiable.
  • Adds a 'Deprecated' bool flag to the Details type.

Why is it important?

I wanted to reuse some parts of the features package, but found it rather complex. Still feature.Details I'd like to keep :)

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

@urso urso added review refactoring libbeat Team:Services (Deprecated) Label for the former Integrations-Services team labels Feb 27, 2020
@urso urso requested review from ph and kvch February 27, 2020 04:13
ph
ph approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the followup on values instead of interface :)
Are we targetting 7.x with that change?

@urso
Copy link
Author

urso commented Feb 27, 2020

Are we targetting 7.x with that change?

I'd say so. I'm using this my input v2 branches.

1 similar comment
@urso
Copy link
Author

urso commented Feb 27, 2020

Are we targetting 7.x with that change?

I'd say so. I'm using this my input v2 branches.

@urso urso added the needs_backport PR is waiting to be backported to other branches. label Feb 27, 2020
@urso urso merged commit 6af4783 into elastic:master Feb 27, 2020
urso pushed a commit to urso/beats that referenced this pull request Feb 27, 2020
Remove feature.Describer and enhance Details (elastic#16658)
5c6d10d 
(cherry picked from commit 6af4783)
@urso urso mentioned this pull request Feb 27, 2020
Merged
1 task
@urso urso added v7.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Feb 27, 2020
urso pushed a commit that referenced this pull request Feb 28, 2020
Cherry-pick #16658 to 7.x: Remove feature.Describer and enhanc… (#16674)
169c010 
(cherry picked from commit 6af4783)
blakerouse pushed a commit to blakerouse/beats that referenced this pull request Feb 28, 2020
@blakerouse
Remove feature.Describer and enhance Details (elastic#16658)
e79af86
blakerouse added a commit that referenced this pull request Mar 2, 2020
@blakerouse @ycombinator
@dedemorton @ph @faec @kaiyan-sheng @jsoriano @mtojek
Add cloudfoundry module to metricbeat (#16671)
07b03a7 
* Split up parts into different metricsets.

* Add value and container metricsets.

* Add documentation.

* Revert metricbeat.yml.

* Run make update.

* Fix documentation add changelog.

* Fix bad change in azure module.

* Run make update.

* Improve reference config.

* Document Kibana Space ID setting (#16622)

* Document Kibana Space ID setting

* Update reference YML files

* Update libbeat/docs/shared-kibana-config.asciidoc

Co-Authored-By: DeDe Morton <[email protected]>

* Updating reference YML files

* Adding link to doc

Co-authored-by: DeDe Morton <[email protected]>

* Remove the special pins type for `ca_sha256` (#16615)

We have changed the type from a special custom type to a slice of
string. This reduce the number of exposed types and make it easier in
general to work with in the tests.

* Remove feature.Describer and enhance Details (#16658)

* Make memqueue.Broker internal (now memqueue.broker) (#16667)

* [docs] Add skeleton files for 7.7 release highlights and breaking changes (#16584)

* [Metricbeat] Add vpc metricset for aws module (#16111)

* Add vpn into vpc metricset
* Add NATGateway and TrasitGateway

* Update cisco.asciidoc (#16434)

* Update cisco.asciidoc

Making Elasticsearch explicit in the instructions

* Update docs source in the module dir

Co-authored-by: Loek van Gool <[email protected]>

* Fix wording in dev guide (#16497)

* Added NetBeat (#12612)

* Close files earlier when generating fields files (#16681)

Fields generator keeps all open files while generating the global
fields.yml file. This is not needed and may lead to "too many open
files" errors in some environments.

* [Metricbeat] Add new module for Redis Enterprise (#16482)

Add metricsets: node, proxy

* Add doppler_address, uaa_address, rlp_address to config.reference.yml.

Co-authored-by: Shaunak Kashyap <[email protected]>
Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: Pier-Hugues Pellerin <[email protected]>
Co-authored-by: Steffen Siering <[email protected]>
Co-authored-by: Fae Charlton <[email protected]>
Co-authored-by: kaiyan-sheng <[email protected]>
Co-authored-by: Loek van Gool <[email protected]>
Co-authored-by: Harold Schreckengost <[email protected]>
Co-authored-by: Jaime Soriano Pastor <[email protected]>
Co-authored-by: Marcin Tojek <[email protected]>
blakerouse added a commit to blakerouse/beats that referenced this pull request Mar 3, 2020
@blakerouse
Add cloudfoundry module to metricbeat (elastic#16671)
44e4375 
* Split up parts into different metricsets.

* Add value and container metricsets.

* Add documentation.

* Revert metricbeat.yml.

* Run make update.

* Fix documentation add changelog.

* Fix bad change in azure module.

* Run make update.

* Improve reference config.

* Document Kibana Space ID setting (elastic#16622)

* Document Kibana Space ID setting

* Update reference YML files

* Update libbeat/docs/shared-kibana-config.asciidoc

Co-Authored-By: DeDe Morton <[email protected]>

* Updating reference YML files

* Adding link to doc

Co-authored-by: DeDe Morton <[email protected]>

* Remove the special pins type for `ca_sha256` (elastic#16615)

We have changed the type from a special custom type to a slice of
string. This reduce the number of exposed types and make it easier in
general to work with in the tests.

* Remove feature.Describer and enhance Details (elastic#16658)

* Make memqueue.Broker internal (now memqueue.broker) (elastic#16667)

* [docs] Add skeleton files for 7.7 release highlights and breaking changes (elastic#16584)

* [Metricbeat] Add vpc metricset for aws module (elastic#16111)

* Add vpn into vpc metricset
* Add NATGateway and TrasitGateway

* Update cisco.asciidoc (elastic#16434)

* Update cisco.asciidoc

Making Elasticsearch explicit in the instructions

* Update docs source in the module dir

Co-authored-by: Loek van Gool <[email protected]>

* Fix wording in dev guide (elastic#16497)

* Added NetBeat (elastic#12612)

* Close files earlier when generating fields files (elastic#16681)

Fields generator keeps all open files while generating the global
fields.yml file. This is not needed and may lead to "too many open
files" errors in some environments.

* [Metricbeat] Add new module for Redis Enterprise (elastic#16482)

Add metricsets: node, proxy

* Add doppler_address, uaa_address, rlp_address to config.reference.yml.

Co-authored-by: Shaunak Kashyap <[email protected]>
Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: Pier-Hugues Pellerin <[email protected]>
Co-authored-by: Steffen Siering <[email protected]>
Co-authored-by: Fae Charlton <[email protected]>
Co-authored-by: kaiyan-sheng <[email protected]>
Co-authored-by: Loek van Gool <[email protected]>
Co-authored-by: Harold Schreckengost <[email protected]>
Co-authored-by: Jaime Soriano Pastor <[email protected]>
Co-authored-by: Marcin Tojek <[email protected]>
(cherry picked from commit 07b03a7)
blakerouse added a commit that referenced this pull request Mar 3, 2020
@blakerouse
Cherry-pick #16671 to 7.x: Add cloudfoundry module to metricbeat (#16741
5f7c5a6 
)

* Add cloudfoundry module to metricbeat (#16671)

* Split up parts into different metricsets.

* Add value and container metricsets.

* Add documentation.

* Revert metricbeat.yml.

* Run make update.

* Fix documentation add changelog.

* Fix bad change in azure module.

* Run make update.

* Improve reference config.

* Document Kibana Space ID setting (#16622)

* Document Kibana Space ID setting

* Update reference YML files

* Update libbeat/docs/shared-kibana-config.asciidoc

Co-Authored-By: DeDe Morton <[email protected]>

* Updating reference YML files

* Adding link to doc

Co-authored-by: DeDe Morton <[email protected]>

* Remove the special pins type for `ca_sha256` (#16615)

We have changed the type from a special custom type to a slice of
string. This reduce the number of exposed types and make it easier in
general to work with in the tests.

* Remove feature.Describer and enhance Details (#16658)

* Make memqueue.Broker internal (now memqueue.broker) (#16667)

* [docs] Add skeleton files for 7.7 release highlights and breaking changes (#16584)

* [Metricbeat] Add vpc metricset for aws module (#16111)

* Add vpn into vpc metricset
* Add NATGateway and TrasitGateway

* Update cisco.asciidoc (#16434)

* Update cisco.asciidoc

Making Elasticsearch explicit in the instructions

* Update docs source in the module dir

Co-authored-by: Loek van Gool <[email protected]>

* Fix wording in dev guide (#16497)

* Added NetBeat (#12612)

* Close files earlier when generating fields files (#16681)

Fields generator keeps all open files while generating the global
fields.yml file. This is not needed and may lead to "too many open
files" errors in some environments.

* [Metricbeat] Add new module for Redis Enterprise (#16482)

Add metricsets: node, proxy

* Add doppler_address, uaa_address, rlp_address to config.reference.yml.

Co-authored-by: Shaunak Kashyap <[email protected]>
Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: Pier-Hugues Pellerin <[email protected]>
Co-authored-by: Steffen Siering <[email protected]>
Co-authored-by: Fae Charlton <[email protected]>
Co-authored-by: kaiyan-sheng <[email protected]>
Co-authored-by: Loek van Gool <[email protected]>
Co-authored-by: Harold Schreckengost <[email protected]>
Co-authored-by: Jaime Soriano Pastor <[email protected]>
Co-authored-by: Marcin Tojek <[email protected]>
(cherry picked from commit 07b03a7)

* Fix changelog.

* Run mage fmt.

* Fix imports to have v7.

* Run mage fmt update.

* Fix changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph approved these changes

@kvch kvch Awaiting requested review from kvch

Assignees
No one assigned
Labels
libbeat refactoring review Team:Services (Deprecated) Label for the former Integrations-Services team v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@urso @ph @andresrc