Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #16468 to 7.x: Add missing var definitions in the manifest files #16574

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Feb 25, 2020

Cherry-pick of PR #16468 to 7.x branch. Original message:

Should fix #16270.

Due to new checks on the configuration file keys in v7.6.0, when running:

filebeat setup --module azure

users get:

Exiting: Error getting config for fileset azure/activitylogs: Error interpreting the template of the input: template: text:2:22: executing "text" at <.connection_string>: map has no entry for key "connection_string"

due to missing to define some of the vars in the manifest file.
This PR does this.

…lastic#16468)

* Add vars

* changelog

* temp

* line

* update

* take test out

(cherry picked from commit da3584d)
@narph narph requested a review from a team as a code owner February 25, 2020 17:28
@narph narph self-assigned this Feb 25, 2020
@narph narph added backport Filebeat Filebeat Team:Platforms Label for the Integrations - Platforms team v7.7.0 [zube]: In Review labels Feb 25, 2020
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@narph narph merged commit 243b0bc into elastic:7.x Feb 26, 2020
@narph narph deleted the backport_16468_7.x branch February 26, 2020 10:02
@narph narph added the test-plan Add this PR to be manual test plan label Mar 27, 2020
@andresrc andresrc added the test-plan-added This PR has been added to the test plan label Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Filebeat Filebeat Team:Platforms Label for the Integrations - Platforms team test-plan Add this PR to be manual test plan test-plan-added This PR has been added to the test plan v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants