Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #16332 to 7.x: Fix versioning of dropwizard image used in tests #16380

Merged
merged 3 commits into from
Feb 18, 2020
Merged

Cherry-pick #16332 to 7.x: Fix versioning of dropwizard image used in tests #16380

merged 3 commits into from
Feb 18, 2020

Conversation

jsoriano
Copy link
Member

Cherry-pick of PR #16332 to 7.x branch. Original message:

What does this PR do?

  • Tag the docker image used for dropwizard tests with the dropwizard metrics version instead of with the maven version used to build it.
  • Use multi staging docker build to build in one image and deploy in another one.
  • Add supported-versions.yml.
  • Test also with 4.1.2.

Why is it important?

  • Uses a more suitable versioning for dropwizard docker images, that can be more easily reused in end to end testing.
  • Previous image was downloading dependencies and building artifacts when run. With this approach everything is pre-built on build time and image directly starts the service when run, so startup is way faster and less error prone.

@jsoriano jsoriano requested a review from a team as a code owner February 18, 2020 11:32
@jsoriano
Fix versioning of dropwizard image used in tests (elastic#16332)
2900105 
Tag the docker image used for dropwizard tests with the dropwizard
metrics version instead of with the maven version used to build it.
Prebuild artifacts so there is no need to download dependencies
and build when running the immages.
Add supported-versions.yml.
Test also with 4.1.2.

(cherry picked from commit 21e1560)
@jsoriano jsoriano merged commit 10ecd27 into elastic:7.x Feb 18, 2020
@jsoriano jsoriano deleted the backport_16332_7.x branch February 18, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees
No one assigned
Labels
backport review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsoriano @ChrsMark