Cherry-pick #15997 to 7.6: Correctly format the path to read data from npipe. #16062
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #15997 to 7.6 branch. Original message:
What does this PR do?
This is not a fix for #15832 this will be tackle in another PR.
When http+npipe:// scheme was initially parsed by the url parser of
metric the generated PATH wasn't correctly setup up this mean that Metricbeat was not able to collect metrics over a npipe. So I've fixed the parsing and the tests.
Why is it important?
Fix an issue to read metric over a named pipe
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesAuthor's Checklist
How to test this PR locally
Now to test the behavior on Windows you will need a beat that expose metrics over
named pipes, you can do so with a configuration like this.
After you can start a Metricbeat instance with the beat modules to
collect the metric information.
If you start metricbeat with the
-e -d "*"
flags this will output anymetrics fetched from the running beat instance.
Related issues