Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] Add dashboard for vpc flow log #16007

Merged
merged 3 commits into from
Feb 3, 2020
Merged

[Filebeat] Add dashboard for vpc flow log #16007

merged 3 commits into from
Feb 3, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Feb 1, 2020 •
edited
Loading

This PR is to add dashboard for vpcflow fileset:
Screen Shot 2020-01-31 at 5 23 24 PM (2)

closes #14969

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner February 1, 2020 00:26
@kaiyan-sheng kaiyan-sheng self-assigned this Feb 1, 2020
@kaiyan-sheng kaiyan-sheng added Filebeat Filebeat in progress Pull request is currently in progress. needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team labels Feb 1, 2020
@kaiyan-sheng kaiyan-sheng added review and removed in progress Pull request is currently in progress. labels Feb 2, 2020
mtojek
mtojek approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think the Geo Location map may need a legend (what does the red/green color mean?)

@kaiyan-sheng
Copy link
Contributor Author

@mtojek I just checked the geo location map, turned out there is a button on it to show layers and that would be the legend for two colors:
Screen Shot 2020-02-03 at 7 45 54 AM

@kaiyan-sheng kaiyan-sheng merged commit 249929e into elastic:master Feb 3, 2020
@kaiyan-sheng kaiyan-sheng deleted the vpc_dashboard branch February 3, 2020 15:06
@kaiyan-sheng kaiyan-sheng mentioned this pull request Feb 3, 2020
Merged
@kaiyan-sheng kaiyan-sheng added v7.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Feb 3, 2020
@kaiyan-sheng kaiyan-sheng mentioned this pull request Feb 3, 2020
Merged
kaiyan-sheng added a commit that referenced this pull request Feb 4, 2020
@kaiyan-sheng
Cherry-pick #16007 to 7.6: [Filebeat] Add dashboard for vpc flow log (#…
2161705 
…16034)

* [Filebeat] Add dashboard for vpc flow log (#16007)

* Add dashboard for vpc flow log
* update doc for aws filebeat module

(cherry picked from commit 249929e)

* update changelog
kaiyan-sheng added a commit that referenced this pull request Feb 4, 2020
@kaiyan-sheng
[Filebeat] Add dashboard for vpc flow log (#16007) (#16033)
2b71a92 
* Add dashboard for vpc flow log
* update doc for aws filebeat module

(cherry picked from commit 249929e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
Filebeat Filebeat review Team:Platforms Label for the Integrations - Platforms team v7.6.0 v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Filebeat] Add dashboard for vpcflow fileset
3 participants
@kaiyan-sheng @mtojek @andresrc