Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetricBeat] Add up metric for health status #15948

Merged
merged 14 commits into from
Feb 3, 2020

Conversation

premendrasingh
Copy link
Contributor

@premendrasingh premendrasingh commented Jan 30, 2020

Enhancement: This PR adds up metric to metrics scraped from host. It will be useful for instance availability monitoring.
Sample metric:
up{job="prometheus",instance="localhost:8080"} 1

@premendrasingh premendrasingh requested a review from a team as a code owner January 30, 2020 01:42
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@exekias exekias added enhancement review Team:Platforms Label for the Integrations - Platforms team labels Jan 30, 2020
@exekias
Copy link
Contributor

exekias commented Jan 30, 2020

Thank you so much for contributing 🎉 ! This PR looks good to me. Could you please check the lint errors? mage fmt would probably fix this.

@exekias exekias self-assigned this Jan 30, 2020
@premendrasingh
Copy link
Contributor Author

@exekias fixed lint error. Thanks for the suggestion.

@exekias
Copy link
Contributor

exekias commented Jan 31, 2020

Tests seem to be failing, we use some golden files to test the output of the module, you can update them with this command:

go test github.com/elastic/beats/metricbeat/module/prometheus/collector -data

@exekias exekias closed this Jan 31, 2020
@exekias exekias reopened this Jan 31, 2020
@exekias
Copy link
Contributor

exekias commented Jan 31, 2020

sorry, wrong button 😇

@premendrasingh
Copy link
Contributor Author

Executed
go test github.com/elastic/beats/metricbeat/module/prometheus/collector -data
Thanks for the suggestion.

@exekias
Copy link
Contributor

exekias commented Feb 3, 2020

ok to test

@exekias exekias added the needs_backport PR is waiting to be backported to other branches. label Feb 3, 2020
@exekias exekias merged commit 1c32be3 into elastic:master Feb 3, 2020
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Feb 3, 2020
exekias pushed a commit to exekias/beats that referenced this pull request Feb 3, 2020
* Add UP metric, useful for instance availability monitoring

(cherry picked from commit 1c32be3)
@exekias exekias added v7.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Feb 3, 2020
@premendrasingh
Copy link
Contributor Author

Thanks a lot @exekias

@exekias
Copy link
Contributor

exekias commented Feb 3, 2020

Thank you!!

exekias pushed a commit that referenced this pull request Feb 4, 2020
…us (#16035)

* [MetricBeat] Add up metric for health status (#15948)

* Add UP metric, useful for instance availability monitoring

(cherry picked from commit 1c32be3)

* Update CHANGELOG.next.asciidoc

Co-authored-by: premendrasingh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement review Team:Platforms Label for the Integrations - Platforms team v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants