Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add galley metricset for Istio Metricbeat module #15857

Merged
merged 8 commits into from
Jan 31, 2020
Merged

Add galley metricset for Istio Metricbeat module #15857

merged 8 commits into from
Jan 31, 2020

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jan 27, 2020 •
edited
Loading

This PR adds galley metricset for istio Module.

The metrics will be collected from the respective Prometheus exporter endpoint:
istio-galley.istio-system:15014: The galley job returns the Galley-generated metrics.

Part of: #15505

Manual testing

  1. Build or download x-pack metricbeat executable
  2. Spin up a Kubernetes cluster with Minikube
  3. Install ISTIO https://istio.io/docs/setup/install/
  4. Expose the istio-galley.istio-system:15014 service to working machine, using kubectl port-forward, kubectl -n istio-system port-forward svc/istio-galley 15014:15014
  5. Enable the istio module, configure it in metricbeat.yaml and start monitoring ISTIO galley

@ChrsMark ChrsMark requested a review from a team January 27, 2020 12:13
@ChrsMark ChrsMark self-assigned this Jan 27, 2020
@ChrsMark ChrsMark mentioned this pull request Jan 27, 2020
Closed
11 tasks
@ChrsMark
Copy link
Member Author

cc-ing @sayden, @jsoriano since you reviewed similar ones recently

jsoriano
jsoriano approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a typo in the docs

x-pack/metricbeat/module/istio/galley/_meta/fields.yml Outdated Show resolved Hide resolved
@ChrsMark
fix typo
c360448 
Signed-off-by: chrismark <[email protected]>
@ChrsMark ChrsMark added v7.7.0 needs_backport PR is waiting to be backported to other branches. labels Jan 30, 2020
@ChrsMark ChrsMark merged commit 1690129 into elastic:master Jan 31, 2020
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Feb 4, 2020
@ChrsMark
Add galley metricset for Istio Metricbeat module (elastic#15857)
8c04b9d 
(cherry picked from commit 1690129)
@ChrsMark ChrsMark mentioned this pull request Feb 4, 2020
Merged
@ChrsMark ChrsMark removed the needs_backport PR is waiting to be backported to other branches. label Feb 4, 2020
ChrsMark added a commit that referenced this pull request Feb 4, 2020
@ChrsMark
Cherry-pick #15857 to 7.x: Add galley metricset for Istio Metricbeat …
0661a51 
…module (#16051)
@ChrsMark ChrsMark added [zube]: Done test-plan Add this PR to be manual test plan labels Feb 4, 2020
@andresrc andresrc added the Team:Platforms Label for the Integrations - Platforms team label Mar 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@andresrc andresrc added the test-plan-added This PR has been added to the test plan label Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@jsoriano jsoriano jsoriano approved these changes

Assignees

@ChrsMark ChrsMark

Labels
enhancement Metricbeat Metricbeat module review Team:Platforms Label for the Integrations - Platforms team test-plan Add this PR to be manual test plan test-plan-added This PR has been added to the test plan v7.7.0 [zube]: Done [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChrsMark @elasticmachine @jsoriano @kaiyan-sheng @andresrc