[Filebeat] move create-[module,fileset,fields] to mage #15836

leehinman · 2020-01-24T19:39:48Z

make create commands available in x-pack/filebeat

- make create commands available in x-pack/filebeat

elasticmachine · 2020-01-24T19:39:50Z

Pinging @elastic/siem (Team:SIEM)

andrewkroh

Nice, I just give it a quick look.

andrewkroh · 2020-01-24T23:42:43Z

filebeat/magefile.go

+		return fmt.Errorf("You must specify the module: MODULE=name mage createModule")
+	}
+
+	filebeatDir, err := os.Getwd()


Use devtools.CWD() as a shortcut. It will panic on error, but that's how errors bubble up in mage.

andrewkroh · 2020-01-24T23:43:57Z

filebeat/magefile.go

@@ -220,3 +224,57 @@ func PythonIntegTest(ctx context.Context) error {
 		return devtools.PythonNoseTest(args)
 	}, "GENERATE", "TESTING_FILEBEAT_MODULES", "TESTING_FILEBEAT_FILESETS")
 }
+


Try putting this into filebeat/scripts/mage/ so that you don't have to duplicate it.

You could put them under filebeat/scripts/mage/generate. Then import them with // mage:import generate so you get targets like mage generate:module.

andrewkroh · 2020-01-24T23:47:26Z

x-pack/filebeat/magefile.go

+	if err != nil {
+		return err
+	}
+	filebeatDir := path.Join(path.Dir(path.Dir(xFilebeatDir)), "filebeat")


I think you want https://godoc.org/github.com/elastic/beats/dev-tools/mage#OSSBeatDir.

houndci-bot · 2020-01-28T03:05:23Z

filebeat/scripts/mage/generate/fields.go

-	modulePath := flag.String("path", ".", "Path to the generated fileset")
-	beatsPath := flag.String("beats_path", ".", "Path to elastic/beats")
-	flag.Parse()
+// CreateFields creates a new fields.yml for an existing Filebeat fileset.


comment on exported function Fields should be of the form "Fields ..."

houndci-bot · 2020-01-28T03:05:23Z

filebeat/scripts/mage/generate/fileset.go

+	genfileset "github.com/elastic/beats/filebeat/generator/fileset"
+)
+
+// CreateFileset creates a new fileset for an existing Filebeat module.


comment on exported function Fileset should be of the form "Fileset ..."

houndci-bot · 2020-01-28T03:05:24Z

filebeat/scripts/mage/generate/fields.go

-	modulePath := flag.String("path", ".", "Path to the generated fileset")
-	beatsPath := flag.String("beats_path", ".", "Path to elastic/beats")
-	flag.Parse()
+// CreateFields creates a new fields.yml for an existing Filebeat fileset.


comment on exported function Fields should be of the form "Fields ..."

andrewkroh

Just a minor suggestion. Otherwise LGTM.

andrewkroh · 2020-01-28T22:00:00Z

filebeat/Makefile

@@ -15,14 +15,14 @@ update: mage
 # Creates a new module. Requires the params MODULE.
 .PHONY: create-module
 create-module:


Add a dependency on the mage target so that make will go install it.

Suggested change

create-module:

create-module: mage

andrewkroh · 2020-02-05T13:14:47Z

filebeat/scripts/mage/generate/module.go

+func Module() error {
+	targetModule := os.Getenv("MODULE")
+	if targetModule == "" {
+		return fmt.Errorf("You must specify the module: MODULE=name mage generate:module")


I like to always start error strings with lowercase chars. https://github.com/golang/go/wiki/CodeReviewComments#error-strings

- move create-[module,fileset,fields] to mage - make mage create commands available in x-pack/filebeat - change Makefile to use mage for create commands (cherry picked from commit 90f79f9)

* [Filebeat] move create-[module,fileset,fields] to mage (#15836) - move create-[module,fileset,fields] to mage - make mage create commands available in x-pack/filebeat - change Makefile to use mage for create commands * Elasticsearch index must be lowercase (#16081) * Index names must be lowercase When indexing into Elasticsearch index names must always be lowercase. If the index or indices setting are configured to produce non-lowercase strings (e.g. by extracting part of the index name from the event contents), we need to normalize them to be lowercase. This change ensure that index names are always converted to lowercase. Static strings are converted to lowercase upfront, while dynamic strings will be post-processed. * update kafka/redis/LS output to guarantee lowercase index * add godoc * Regenerate expected files after changes in date parsing (#16139) Elasticsearch has modified the behaviour on date parsing when the date doesn't include timezone data. Regenerate a couple of golden files that are affected by this change. * Add autodiscover for aws_ec2 (#14823) * Add autodiscover for aws_ec2 * Add aws.ec2.* to autodiscover template * Fix a connection error in httpjson input (#16123) * Fix a connection error in httpjson input * Include document_id in decode_json_fields allowed fields (#16156) * ci: run test on Windows (#15570) * feat: run test on Windows * chore: parameter to enable/disable windows test * deleteDir before of the checkout * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Apply suggestions from code review * feat: apply dependency hierarchies * fit: use isChanged for all matches, and add the libbeat match where it is needed * feat: add x-pack/winlogbeat windows unit tests * fix: duplicate when condition * Update Jenkinsfile Co-Authored-By: Andrew Kroh <[email protected]> Co-authored-by: Andrew Kroh <[email protected]> * improve kubernetes.pod.cpu.usage.limit.pct field description (#16128) * upgrade github.com/gogo/protobuf/... to v1.3.1 (#16138) * [Filebeat] Add ECS tls & categorization fields to apache module (#16121) * Add ECS tls & categorization fields to apache module - tls.cipher (access) - tls.protocol (access) - tls.protocol_version (access) - event.kind (access) - event.category (access) - event.outcome (access) - lowercase http.request.method for ECS compliance (access) - event.kind (error) - event.category (error) - event.type (error) Closes #16032 * [Metricbeat] Add Overview dashboard to Tomcat module * [Metricbeat] Fix PostgreSQL Dashboard (#16132) * [Metricbeat] Fix PostgreSQL Dashboard * Update version * Fix: imports order (#16207) * [Metricbeat]kube-state-metrics: add storage class support (#16145) * add ksm storage class support * [Journalbeat] Improve parsing of syslog.pid in journalbeat to strip the username when present (#16116) * Improve parsing of syslog.pid in journalbeat to strip the username in pid when present. * Add entry to changelog with pull ID. * Improve the comment on the username strip. * [Agent] Allow CA cert pinning on the Elasticsearch output or any code that user tlscommon.TLSConfig builder. (#16019) * Add a sha256 pin for the CA Certificate When multiples CA are presents on the system we cannot ensure that a specific one was used to validates the chains exposer by the server. This PRs adds a `ca_sha256` option to the `tlscommon.TLSConfig` that is used by all the code that has to create a TCP client with TLS support. When the option is set, it will hook a new callback in the validation chains that will inspect the verified and validated chains by Go to ensure that a lets a certificate in the chains match the provided sha256. Usage example for the Elasticsearch output. ``` output.elasticsearch: hosts: [127.0.0.1:9200] ssl.ca_sha256: <base64_encoded_sha1> ``` You can generate the pin using the **openssl** binary with the following command: ``` openssl x509 -in ca.crt -pubkey -noout | openssl pkey -pubin -outform der | openssl dgst -sha256 -binary | openssl enc -base64 ``` OpenSSL's [documentation](https://www.openssl.org/docs/manmaster/man1/dgst.html) You will need to start Elasticsearch with the following options ```yaml xpack.security.enabled: true indices.id_field_data.enabled: true xpack.license.self_generated.type: trial xpack.security.http.ssl.enabled: true xpack.security.http.ssl.key: /etc/pki/localhost/localhost.key" xpack.security.http.ssl.certificate: /etc/pki/localhost/localhost.crt" xpack.security.http.ssl.certificate_authorities: /etc/pki/ca/ca.crt" ``` This pull request also include a new service in the docker-compose.yml that will start a new Elasticsearch server with TLS and security configured. * [docs] Add 7.6 breaking changes and release highlights (#16202) * [docs] Add early draft of Elastic Log Driver docs (#15799) * Index template will only be loaded if the configured output is Elasticsearch or Elastic Cloud (#16124) (#16225) Minor update to be more explicit on the index template loading requirement. Co-authored-by: romain-chanu <[email protected]> * Remove spaces in prometheus commented out option (#16233) * Fix: don't miss address scheme (#16205) * Fix: don't miss address scheme * Add unit test * Adjust source after code review * Add comment to method * Freeze virtualenv version until issue with CI is resolved (#16235) * [docs] Fix install command to match instructions on docker hub (#16249) * [docs] Add link to observability release blog (#16246) * ci(jenkins): enable fix-permissions to be executed without running make too (#16130) * ci(jenkins): enable fix-permissions to be executed without running make too * ci(jenkins): go modules are stored in the HOME path * ci(jenkins): fix permissions should run only if docker is enabled * Upgrade go-ucfg to version 0.8.2 (#16199) * Upgrade go-ucfg to master, for testing before 0.8.2 release. * Update notice. * Fix tests. * Update to the v0.8.2 release tag and remake NOTICE.txt. * Improve test name. * Add ingress nginx controller fileset (#16197) * update notice Co-authored-by: Lee Hinman <[email protected]> Co-authored-by: Steffen Siering <[email protected]> Co-authored-by: Jaime Soriano Pastor <[email protected]> Co-authored-by: kaiyan-sheng <[email protected]> Co-authored-by: Lei Qiu <[email protected]> Co-authored-by: Fae Charlton <[email protected]> Co-authored-by: Ivan Fernandez Calvo <[email protected]> Co-authored-by: Andrew Kroh <[email protected]> Co-authored-by: Chris Mark <[email protected]> Co-authored-by: Gil Raphaelli <[email protected]> Co-authored-by: Mario Castro <[email protected]> Co-authored-by: Dimitri Mazmanov <[email protected]> Co-authored-by: Marcin Tojek <[email protected]> Co-authored-by: Pablo Mercado <[email protected]> Co-authored-by: Blake Rouse <[email protected]> Co-authored-by: Pier-Hugues Pellerin <[email protected]> Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: romain-chanu <[email protected]> Co-authored-by: Michal Pristas <[email protected]> Co-authored-by: Victor Martinez <[email protected]>

- move create-[module,fileset,fields] to mage - make mage create commands available in x-pack/filebeat - change Makefile to use mage for create commands

* [Filebeat] move create-[module,fileset,fields] to mage (#15836) - move create-[module,fileset,fields] to mage - make mage create commands available in x-pack/filebeat - change Makefile to use mage for create commands * Elasticsearch index must be lowercase (#16081) * Index names must be lowercase When indexing into Elasticsearch index names must always be lowercase. If the index or indices setting are configured to produce non-lowercase strings (e.g. by extracting part of the index name from the event contents), we need to normalize them to be lowercase. This change ensure that index names are always converted to lowercase. Static strings are converted to lowercase upfront, while dynamic strings will be post-processed. * update kafka/redis/LS output to guarantee lowercase index * add godoc * Regenerate expected files after changes in date parsing (#16139) Elasticsearch has modified the behaviour on date parsing when the date doesn't include timezone data. Regenerate a couple of golden files that are affected by this change. * Add autodiscover for aws_ec2 (#14823) * Add autodiscover for aws_ec2 * Add aws.ec2.* to autodiscover template * Fix a connection error in httpjson input (#16123) * Fix a connection error in httpjson input * Include document_id in decode_json_fields allowed fields (#16156) * ci: run test on Windows (#15570) * feat: run test on Windows * chore: parameter to enable/disable windows test * deleteDir before of the checkout * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Apply suggestions from code review * feat: apply dependency hierarchies * fit: use isChanged for all matches, and add the libbeat match where it is needed * feat: add x-pack/winlogbeat windows unit tests * fix: duplicate when condition * Update Jenkinsfile Co-Authored-By: Andrew Kroh <[email protected]> Co-authored-by: Andrew Kroh <[email protected]> * improve kubernetes.pod.cpu.usage.limit.pct field description (#16128) * upgrade github.com/gogo/protobuf/... to v1.3.1 (#16138) * [Filebeat] Add ECS tls & categorization fields to apache module (#16121) * Add ECS tls & categorization fields to apache module - tls.cipher (access) - tls.protocol (access) - tls.protocol_version (access) - event.kind (access) - event.category (access) - event.outcome (access) - lowercase http.request.method for ECS compliance (access) - event.kind (error) - event.category (error) - event.type (error) Closes #16032 * [Metricbeat] Add Overview dashboard to Tomcat module * [Metricbeat] Fix PostgreSQL Dashboard (#16132) * [Metricbeat] Fix PostgreSQL Dashboard * Update version * Fix: imports order (#16207) * [Metricbeat]kube-state-metrics: add storage class support (#16145) * add ksm storage class support * [Journalbeat] Improve parsing of syslog.pid in journalbeat to strip the username when present (#16116) * Improve parsing of syslog.pid in journalbeat to strip the username in pid when present. * Add entry to changelog with pull ID. * Improve the comment on the username strip. * [Agent] Allow CA cert pinning on the Elasticsearch output or any code that user tlscommon.TLSConfig builder. (#16019) * Add a sha256 pin for the CA Certificate When multiples CA are presents on the system we cannot ensure that a specific one was used to validates the chains exposer by the server. This PRs adds a `ca_sha256` option to the `tlscommon.TLSConfig` that is used by all the code that has to create a TCP client with TLS support. When the option is set, it will hook a new callback in the validation chains that will inspect the verified and validated chains by Go to ensure that a lets a certificate in the chains match the provided sha256. Usage example for the Elasticsearch output. ``` output.elasticsearch: hosts: [127.0.0.1:9200] ssl.ca_sha256: <base64_encoded_sha1> ``` You can generate the pin using the **openssl** binary with the following command: ``` openssl x509 -in ca.crt -pubkey -noout | openssl pkey -pubin -outform der | openssl dgst -sha256 -binary | openssl enc -base64 ``` OpenSSL's [documentation](https://www.openssl.org/docs/manmaster/man1/dgst.html) You will need to start Elasticsearch with the following options ```yaml xpack.security.enabled: true indices.id_field_data.enabled: true xpack.license.self_generated.type: trial xpack.security.http.ssl.enabled: true xpack.security.http.ssl.key: /etc/pki/localhost/localhost.key" xpack.security.http.ssl.certificate: /etc/pki/localhost/localhost.crt" xpack.security.http.ssl.certificate_authorities: /etc/pki/ca/ca.crt" ``` This pull request also include a new service in the docker-compose.yml that will start a new Elasticsearch server with TLS and security configured. * [docs] Add 7.6 breaking changes and release highlights (#16202) * [docs] Add early draft of Elastic Log Driver docs (#15799) * Index template will only be loaded if the configured output is Elasticsearch or Elastic Cloud (#16124) (#16225) Minor update to be more explicit on the index template loading requirement. Co-authored-by: romain-chanu <[email protected]> * Remove spaces in prometheus commented out option (#16233) * Fix: don't miss address scheme (#16205) * Fix: don't miss address scheme * Add unit test * Adjust source after code review * Add comment to method * Freeze virtualenv version until issue with CI is resolved (#16235) * [docs] Fix install command to match instructions on docker hub (#16249) * [docs] Add link to observability release blog (#16246) * ci(jenkins): enable fix-permissions to be executed without running make too (#16130) * ci(jenkins): enable fix-permissions to be executed without running make too * ci(jenkins): go modules are stored in the HOME path * ci(jenkins): fix permissions should run only if docker is enabled * Upgrade go-ucfg to version 0.8.2 (#16199) * Upgrade go-ucfg to master, for testing before 0.8.2 release. * Update notice. * Fix tests. * Update to the v0.8.2 release tag and remake NOTICE.txt. * Improve test name. * Add ingress nginx controller fileset (#16197) * update notice Co-authored-by: Lee Hinman <[email protected]> Co-authored-by: Steffen Siering <[email protected]> Co-authored-by: Jaime Soriano Pastor <[email protected]> Co-authored-by: kaiyan-sheng <[email protected]> Co-authored-by: Lei Qiu <[email protected]> Co-authored-by: Fae Charlton <[email protected]> Co-authored-by: Ivan Fernandez Calvo <[email protected]> Co-authored-by: Andrew Kroh <[email protected]> Co-authored-by: Chris Mark <[email protected]> Co-authored-by: Gil Raphaelli <[email protected]> Co-authored-by: Mario Castro <[email protected]> Co-authored-by: Dimitri Mazmanov <[email protected]> Co-authored-by: Marcin Tojek <[email protected]> Co-authored-by: Pablo Mercado <[email protected]> Co-authored-by: Blake Rouse <[email protected]> Co-authored-by: Pier-Hugues Pellerin <[email protected]> Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: romain-chanu <[email protected]> Co-authored-by: Michal Pristas <[email protected]> Co-authored-by: Victor Martinez <[email protected]>

andrewkroh · 2020-05-06T01:20:42Z

Backported in #16140.

* [Filebeat] move create-[module,fileset,fields] to mage (elastic#15836) - move create-[module,fileset,fields] to mage - make mage create commands available in x-pack/filebeat - change Makefile to use mage for create commands * Elasticsearch index must be lowercase (elastic#16081) * Index names must be lowercase When indexing into Elasticsearch index names must always be lowercase. If the index or indices setting are configured to produce non-lowercase strings (e.g. by extracting part of the index name from the event contents), we need to normalize them to be lowercase. This change ensure that index names are always converted to lowercase. Static strings are converted to lowercase upfront, while dynamic strings will be post-processed. * update kafka/redis/LS output to guarantee lowercase index * add godoc * Regenerate expected files after changes in date parsing (elastic#16139) Elasticsearch has modified the behaviour on date parsing when the date doesn't include timezone data. Regenerate a couple of golden files that are affected by this change. * Add autodiscover for aws_ec2 (elastic#14823) * Add autodiscover for aws_ec2 * Add aws.ec2.* to autodiscover template * Fix a connection error in httpjson input (elastic#16123) * Fix a connection error in httpjson input * Include document_id in decode_json_fields allowed fields (elastic#16156) * ci: run test on Windows (elastic#15570) * feat: run test on Windows * chore: parameter to enable/disable windows test * deleteDir before of the checkout * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Apply suggestions from code review * feat: apply dependency hierarchies * fit: use isChanged for all matches, and add the libbeat match where it is needed * feat: add x-pack/winlogbeat windows unit tests * fix: duplicate when condition * Update Jenkinsfile Co-Authored-By: Andrew Kroh <[email protected]> Co-authored-by: Andrew Kroh <[email protected]> * improve kubernetes.pod.cpu.usage.limit.pct field description (elastic#16128) * upgrade github.com/gogo/protobuf/... to v1.3.1 (elastic#16138) * [Filebeat] Add ECS tls & categorization fields to apache module (elastic#16121) * Add ECS tls & categorization fields to apache module - tls.cipher (access) - tls.protocol (access) - tls.protocol_version (access) - event.kind (access) - event.category (access) - event.outcome (access) - lowercase http.request.method for ECS compliance (access) - event.kind (error) - event.category (error) - event.type (error) Closes elastic#16032 * [Metricbeat] Add Overview dashboard to Tomcat module * [Metricbeat] Fix PostgreSQL Dashboard (elastic#16132) * [Metricbeat] Fix PostgreSQL Dashboard * Update version * Fix: imports order (elastic#16207) * [Metricbeat]kube-state-metrics: add storage class support (elastic#16145) * add ksm storage class support * [Journalbeat] Improve parsing of syslog.pid in journalbeat to strip the username when present (elastic#16116) * Improve parsing of syslog.pid in journalbeat to strip the username in pid when present. * Add entry to changelog with pull ID. * Improve the comment on the username strip. * [Agent] Allow CA cert pinning on the Elasticsearch output or any code that user tlscommon.TLSConfig builder. (elastic#16019) * Add a sha256 pin for the CA Certificate When multiples CA are presents on the system we cannot ensure that a specific one was used to validates the chains exposer by the server. This PRs adds a `ca_sha256` option to the `tlscommon.TLSConfig` that is used by all the code that has to create a TCP client with TLS support. When the option is set, it will hook a new callback in the validation chains that will inspect the verified and validated chains by Go to ensure that a lets a certificate in the chains match the provided sha256. Usage example for the Elasticsearch output. ``` output.elasticsearch: hosts: [127.0.0.1:9200] ssl.ca_sha256: <base64_encoded_sha1> ``` You can generate the pin using the **openssl** binary with the following command: ``` openssl x509 -in ca.crt -pubkey -noout | openssl pkey -pubin -outform der | openssl dgst -sha256 -binary | openssl enc -base64 ``` OpenSSL's [documentation](https://www.openssl.org/docs/manmaster/man1/dgst.html) You will need to start Elasticsearch with the following options ```yaml xpack.security.enabled: true indices.id_field_data.enabled: true xpack.license.self_generated.type: trial xpack.security.http.ssl.enabled: true xpack.security.http.ssl.key: /etc/pki/localhost/localhost.key" xpack.security.http.ssl.certificate: /etc/pki/localhost/localhost.crt" xpack.security.http.ssl.certificate_authorities: /etc/pki/ca/ca.crt" ``` This pull request also include a new service in the docker-compose.yml that will start a new Elasticsearch server with TLS and security configured. * [docs] Add 7.6 breaking changes and release highlights (elastic#16202) * [docs] Add early draft of Elastic Log Driver docs (elastic#15799) * Index template will only be loaded if the configured output is Elasticsearch or Elastic Cloud (elastic#16124) (elastic#16225) Minor update to be more explicit on the index template loading requirement. Co-authored-by: romain-chanu <[email protected]> * Remove spaces in prometheus commented out option (elastic#16233) * Fix: don't miss address scheme (elastic#16205) * Fix: don't miss address scheme * Add unit test * Adjust source after code review * Add comment to method * Freeze virtualenv version until issue with CI is resolved (elastic#16235) * [docs] Fix install command to match instructions on docker hub (elastic#16249) * [docs] Add link to observability release blog (elastic#16246) * ci(jenkins): enable fix-permissions to be executed without running make too (elastic#16130) * ci(jenkins): enable fix-permissions to be executed without running make too * ci(jenkins): go modules are stored in the HOME path * ci(jenkins): fix permissions should run only if docker is enabled * Upgrade go-ucfg to version 0.8.2 (elastic#16199) * Upgrade go-ucfg to master, for testing before 0.8.2 release. * Update notice. * Fix tests. * Update to the v0.8.2 release tag and remake NOTICE.txt. * Improve test name. * Add ingress nginx controller fileset (elastic#16197) * update notice Co-authored-by: Lee Hinman <[email protected]> Co-authored-by: Steffen Siering <[email protected]> Co-authored-by: Jaime Soriano Pastor <[email protected]> Co-authored-by: kaiyan-sheng <[email protected]> Co-authored-by: Lei Qiu <[email protected]> Co-authored-by: Fae Charlton <[email protected]> Co-authored-by: Ivan Fernandez Calvo <[email protected]> Co-authored-by: Andrew Kroh <[email protected]> Co-authored-by: Chris Mark <[email protected]> Co-authored-by: Gil Raphaelli <[email protected]> Co-authored-by: Mario Castro <[email protected]> Co-authored-by: Dimitri Mazmanov <[email protected]> Co-authored-by: Marcin Tojek <[email protected]> Co-authored-by: Pablo Mercado <[email protected]> Co-authored-by: Blake Rouse <[email protected]> Co-authored-by: Pier-Hugues Pellerin <[email protected]> Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: romain-chanu <[email protected]> Co-authored-by: Michal Pristas <[email protected]> Co-authored-by: Victor Martinez <[email protected]>

move create-[module,fileset,fields] to mage

908c4d8

- make create commands available in x-pack/filebeat

leehinman added enhancement Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Team:SIEM labels Jan 24, 2020

leehinman requested review from adriansr and andrewkroh January 24, 2020 19:39

andrewkroh reviewed Jan 24, 2020

View reviewed changes

houndci-bot reviewed Jan 28, 2020

View reviewed changes

Switch to importing mage targets

c9c7b32

leehinman force-pushed the makefile_to_magefile branch from f7e49d2 to c9c7b32 Compare January 28, 2020 03:07

leehinman marked this pull request as ready for review January 28, 2020 14:49

andrewkroh approved these changes Feb 5, 2020

View reviewed changes

Add Makefile dependency, fix error strings

8408bb3

andrewkroh approved these changes Feb 5, 2020

View reviewed changes

Merge branch 'master' into makefile_to_magefile

8095f37

leehinman merged commit 90f79f9 into elastic:master Feb 6, 2020

andrewkroh removed the needs_backport PR is waiting to be backported to other branches. label May 6, 2020

leehinman deleted the makefile_to_magefile branch October 5, 2020 19:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Filebeat] move create-[module,fileset,fields] to mage #15836

[Filebeat] move create-[module,fileset,fields] to mage #15836

leehinman commented Jan 24, 2020

elasticmachine commented Jan 24, 2020

andrewkroh left a comment

andrewkroh Jan 24, 2020

andrewkroh Jan 24, 2020

andrewkroh Jan 24, 2020

andrewkroh Jan 24, 2020

houndci-bot Jan 28, 2020

houndci-bot Jan 28, 2020

houndci-bot Jan 28, 2020

andrewkroh left a comment

andrewkroh Jan 28, 2020

andrewkroh Feb 5, 2020

andrewkroh commented May 6, 2020

[Filebeat] move create-[module,fileset,fields] to mage #15836

[Filebeat] move create-[module,fileset,fields] to mage #15836

Conversation

leehinman commented Jan 24, 2020

elasticmachine commented Jan 24, 2020

andrewkroh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewkroh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewkroh commented May 6, 2020