Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable removed tests in test_registrar #15790

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

urso
Copy link

@urso urso commented Jan 23, 2020

What does this PR do?

Unskip flaky filebeat system tests that rely on file removal detection in test_registrar.py

Why is it important?

Improvements for detecting file removal have been introduced a while
ago. Filebeat doesn't wait until EOF when trying to detect removal. On
windows we also introduced some extra API call to detect file-deletion
flags being set.

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files
- [ ] I have added tests that prove my fix is effective or that my feature works

Author's Checklist

Check Filebeat tests did not fail on unskipped tests by rerunning tests a few times on jenkins (only windows tests are affected)

  • run 1
  • run 2
  • run 3
  • run 4
  • run 5
  • run 6
  • run 7
  • run 8

Related issues

Improvements for detecting file removal have been introduced a while
ago. Filebeat doesn't wait until EOF when trying to detect removal. On
windows we also introduced some extra API call to detect file-deletion
flags being set.
@urso urso added Filebeat Filebeat in progress Pull request is currently in progress. Team:Beats labels Jan 23, 2020
@urso urso requested a review from ycombinator January 23, 2020 20:22
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess we should run CI on this a few times to make sure it's not flaky anymore?

@urso
Copy link
Author

urso commented Jan 24, 2020

Jenkins, test this.

3 similar comments
@urso
Copy link
Author

urso commented Jan 24, 2020

Jenkins, test this.

@urso
Copy link
Author

urso commented Jan 27, 2020

Jenkins, test this.

@urso
Copy link
Author

urso commented Jan 27, 2020

Jenkins, test this.

@ycombinator
Copy link
Contributor

jenkins, test this

@ycombinator
Copy link
Contributor

jenkins, test this

@urso
Copy link
Author

urso commented Jan 28, 2020

Jenkins, test this.

@urso
Copy link
Author

urso commented Jan 28, 2020

Merging. The unskipped tests did not fail in any CI run (total 8 runs).

@urso urso merged commit 150fbb8 into elastic:master Jan 28, 2020
@urso urso deleted the reenable-removed-tests branch January 28, 2020 22:54
@urso urso added review and removed in progress Pull request is currently in progress. labels Jan 28, 2020
@andresrc andresrc added the Team:Integrations Label for the Integrations team label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Filebeat Filebeat review Team:Integrations Label for the Integrations team
Projects
None yet
3 participants