Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metricbeat system test fixes (Python3 branch) #15779

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Metricbeat system test fixes (Python3 branch) #15779

merged 1 commit into from
Jan 24, 2020

Conversation

andrewkroh
Copy link
Member

0af1703 - Add missing integration_tests check to metricbeat xpack test

This Elasticsearch test was running with the unit test target and failing since ES wasn't available.

7eb1e52 - Update Kibana version used in x-pack/metricbeat

It was failing with:

2020-01-23T00:00:05.715Z        DEBUG   [dashboards]    dashboards/kibana_loader.go:146 Initialize the Kibana 7.4.0 loader
2020-01-23T00:00:05.715Z        DEBUG   [dashboards]    dashboards/kibana_loader.go:146 Kibana URL http://172.20.0.3:5601

2020-01-23T00:01:22.639Z        DEBUG   [dashboards]    dashboards/kibana_loader.go:146 Import dashboard from /go/src/github.com/elastic/beats/x-pack/metricbeat/build/system-tests/run/test_xpack_base.Test.test_dashboards/kibana/7/dashboard/metricbeat-windows-service.json
2020-01-23T00:01:23.721Z        ERROR   instance/beat.go:921    Exiting: Failed to import dashboard: Failed to load directory /go/src/github.com/elastic/beats/x-pack/metricbeat/build/system-tests/run/test_xpack_base.Test.test_dashboards/kibana/7/dashboard:
  error loading /go/src/github.com/elastic/beats/x-pack/metricbeat/build/system-tests/run/test_xpack_base.Test.test_dashboards/kibana/7/dashboard/Metricbeat-aws-lambda-overview.json: returned 422 to import file: <nil>. Response: {"statusCode":422,"error":"Unprocessable Entity","message":"Document \"deab0260-2981-11e9-86eb-a3a07a77f530\" has property \"visualization\" which belongs to a more recent version of Kibana (7.4.2)."}
Exiting: Failed to import dashboard: Failed to load directory /go/src/github.com/elastic/beats/x-pack/metricbeat/build/system-tests/run/test_xpack_base.Test.test_dashboards/kibana/7/dashboard:
  error loading /go/src/github.com/elastic/beats/x-pack/metricbeat/build/system-tests/run/test_xpack_base.Test.test_dashboards/kibana/7/dashboard/Metricbeat-aws-lambda-overview.json: returned 422 to import file: <nil>. Response: {"statusCode":422,"error":"Unprocessable Entity","message":"Document \"deab0260-2981-11e9-86eb-a3a07a77f530\" has property \"visualization\" which belongs to a more recent version of Kibana (7.4.2)."}

@andrewkroh
Add missing integration_tests check to metricbeat xpack test
0af1703 
This test was running with the unit test target and failing.
@andrewkroh andrewkroh requested a review from jsoriano January 23, 2020 15:22
@andrewkroh andrewkroh requested a review from a team as a code owner January 23, 2020 15:22
@andrewkroh
Copy link
Member Author

Locally I'm still seeing x-pack/metricbeat's ActiveMQ system tests failing. Let's see if Travis has the same issue.

jsoriano
jsoriano reviewed Jan 23, 2020
View reviewed changes
metricbeat/module/elasticsearch/test_elasticsearch.py
@@ -74,6 +74,7 @@ def test_metricsets(self, metricset):
self.check_metricset("elasticsearch", metricset, self.get_hosts(), self.FIELDS +
["service"], extras={"index_recovery.active_only": "false"})

@unittest.skipUnless(metricbeat.INTEGRATION_TESTS, "integration test")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, isn't it failing in master?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably should be failing in master. Perhaps we don't run these tests outside of the INTEGRATION_TEST=true environment any where on CI.

x-pack/metricbeat/docker-compose.yml Outdated
@@ -23,11 +23,11 @@ services:
kibana:
# Copied configuration from OSS metricbeat because services with depends_on
# cannot be extended with extends
image: docker.elastic.co/integrations-ci/beats-kibana:${KIBANA_VERSION:-7.4.0}-1
image: docker.elastic.co/integrations-ci/beats-kibana:${KIBANA_VERSION:-7.5.2}-1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we upgrade kibana here we should also do it in the OSS docker-compose.yml, and we should also upgrade ES.

The issue with the lambda dashboard is already fixed in master (#15682) so it should be fixed in the next update we do.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove.

@jsoriano
Copy link
Member

Locally I'm still seeing x-pack/metricbeat's ActiveMQ system tests failing. Let's see if Travis has the same issue.

I am fixing this issue in #15807 (see f4e0187), it seems that dict order changes in python 3 and it was working by chance with python 2.

@jsoriano
Copy link
Member

Issue with dashboards should be also fixed by #15807

@jsoriano
Copy link
Member

I think we can merge this branch with the change for the ES integration tests only.

@jsoriano jsoriano mentioned this pull request Jan 24, 2020
Merged
63 tasks
@andrewkroh andrewkroh force-pushed the feature/python3-metricbeat branch from 7eb1e52 to 0af1703 Compare January 24, 2020 16:04
@andrewkroh andrewkroh merged commit 66250f0 into elastic:feature/python3 Jan 24, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@andrewkroh
Add missing integration_tests check to metricbeat xpack test (elastic…
6175a53 
…#15779)

This test was running with the unit test target and failing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewkroh @jsoriano