Fix filebeat to perseve log.level in event from json reader #15562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
reviewed
Jan 15, 2020
| // event keys are not overwritten, but any nesting of map values is still added to the event. | ||
| fields := common.MapStr(keys) | ||
| fields.DeepUpdate(event.Fields) | ||
| event.Fields.Update(fields) |
There was a problem hiding this comment.
the @timestamp and @metadata keys are special and must not be written to event.Fields.
Is this change enough? If overwriteKeys is true the default in case on the switch statement still uses event.Fields[k] = v, but might instead require a deep update (if k is a map).
blakerouse
changed the title
andresrc
added
Team:Services
|
Need this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix filebeat to perserve log.level in event from json reader.
Closes #12040