Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Add PubSub metricset to Google Cloud Platform module #15536
[Metricbeat] Add PubSub metricset to Google Cloud Platform module #15536
Changes from 10 commits
33f6bcc
d785471
478fed8
b52de5a
4b53e7b
c8fc816
3ea4006
62a16f6
6954190
9e64083
250c9b3
02fc270
3fb61bf
a497458
b915c60
72d70ca
b9527cb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious is the label key here resource.subscription_id? I understand the value is
test-subscription
, but not sure whats theresource
part. Thanks!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more like a property but we thought it was a bit too "complex" to talk about metadata, labels, resources, properties... so we joined all of them into "labels".
This information comes on each response of the Stackdriver API. The one you mention here is a resource label as you can see in the link (follow MonitoredResource link too). You can also find "system" labels, "user" labels and instead of having a bunch of
user.labels.*
,resource.labels.*
,system.labels.*
we swapped the.labels
part to just have everything under the keylabels.*
For example, resource labels in
compute
are the instance type or the storage type. User labels are a key-value you can set in gcp console.In this case, PubSub don't have the specific implementation to gather
user
labels so we are missing the data that the user might input in the console. This data uses PubSub API and not Stackdriver API, that's why each metricset requires an specific implementation inside the stackdriver metricsetI'm not sure if I did a very good job explaining this now, frankly 😅