Include log.source.address for unparseable syslog messages #15453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
enhancement
review
Filebeat
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jan 13, 2020
…5453) Source address was being included in syslog events, but if the syslog message failed to be parsed the event was being generated without this information. Add it in any case. Co-authored-by: Brian Candler <[email protected]> (cherry picked from commit d552e90)
jsoriano
removed
the
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jan 13, 2020
…5453) Source address was being included in syslog events, but if the syslog message failed to be parsed the event was being generated without this information. Add it in any case. Co-authored-by: Brian Candler <[email protected]> (cherry picked from commit d552e90)
|
@ph I was not sure if backporting it for 7.5.2 too, as it could be also considered a bug. I have opened the PR by now, let me know what you think. |
|
@jsoriano I would yes/no but that would still improve the user behavior so I am ok to backport it to 7.5.2 |
ycombinator
pushed a commit
that referenced
this pull request
Jan 15, 2020
… syslog messages (#15495) * Include log.source.address for unparseable syslog messages (#15453) Source address was being included in syslog events, but if the syslog message failed to be parsed the event was being generated without this information. Add it in any case. Co-authored-by: Brian Candler <[email protected]> (cherry picked from commit d552e90) * Fix changelog
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jan 15, 2020
…5453) Source address was being included in syslog events, but if the syslog message failed to be parsed the event was being generated without this information. Add it in any case. Co-authored-by: Brian Candler <[email protected]> (cherry picked from commit d552e90)
jsoriano
added a commit
that referenced
this pull request
Jan 15, 2020
… syslog messages (#15494) Source address was being included in syslog events, but if the syslog message failed to be parsed the event was being generated without this information. Add it in any case. (cherry picked from commit d552e90) Co-authored-by: Brian Candler <[email protected]>
jsoriano
added a commit
that referenced
this pull request
Jan 15, 2020
…15574) Source address was being included in syslog events, but if the syslog message failed to be parsed the event was being generated without this information. Add it in any case. (cherry picked from commit d552e90) Co-authored-by: Brian Candler <[email protected]>
|
Tested manually with BC1 and I see |
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…rseable syslog messages (elastic#15495) * Include log.source.address for unparseable syslog messages (elastic#15453) Source address was being included in syslog events, but if the syslog message failed to be parsed the event was being generated without this information. Add it in any case. Co-authored-by: Brian Candler <[email protected]> (cherry picked from commit f16fdb1) * Fix changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues with #13274, fixes #13268.
How to test:
Co-authored-by: Brian Candler [email protected]