[metricbeat] Fallback to different CPU calculation if we have no online_cpu count #15070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
added
the
needs_backport
exekias
approved these changes
Dec 12, 2019
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Dec 12, 2019
…ne_cpu count (elastic#15070) * fallback to different CPU calculation if we have no online_cpu count (cherry picked from commit c11e57f)
fearful-symmetry
removed
the
needs_backport
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Jan 14, 2020
…ne_cpu count (elastic#15070) * fallback to different CPU calculation if we have no online_cpu count (cherry picked from commit c11e57f)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…on if we have no online_cpu count (elastic#15082) * [metricbeat] Fallback to different CPU calculation if we have no online_cpu count (elastic#15070)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, apparently CentOS VMs on Azure will use an odd (but apparently supported) version of docker that does not give you an
online_cpufield with the container/statsrequest. This breaks thecpu.*.pctfields, which use cpu count in their calculations. Previous versions used a length count:However, we can't just fall back to this, for reasons outlined in #13674. It seems we're not the first people to run into that issue, see coreos/bugs#2088 .
So, we're instead looping through
PercpuUsageand using non-zero fields. This is assuming that per-cpu usage is never zero. This is kinda ugly, but hopefully this is an edge case we won't hit too often.