[Docker Log driver] Expand testing, add mocking tooling #14828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
force-pushed
the
dockerbeat-testing-additional
branch
from
555480c to
da26d09
Compare
mtojek
reviewed
Nov 28, 2019
mtojek
reviewed
Nov 28, 2019
mtojek
reviewed
Nov 28, 2019
|
Only some nit picks, LGTM! |
urso
reviewed
Nov 28, 2019
urso
reviewed
Nov 28, 2019
urso
reviewed
Nov 28, 2019
urso
reviewed
Nov 28, 2019
urso
reviewed
Dec 3, 2019
26 tasks
urso
reviewed
Dec 3, 2019
| assert.Equal(t, event.Fields["message"], logString) | ||
| } | ||
|
|
||
| func setupTestClient(t *testing.T, logString string) (*pipelinemock.MockPipelineConnector, func()) { |
There was a problem hiding this comment.
nit; the function name does not match the return type. Where do we create and publish the event?
There was a problem hiding this comment.
Alright, cleaned this up and adding some comments that hopefully clarify this.
urso
approved these changes
Dec 4, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Add more integration tests and a mock framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a 'main' integration test for the client handler and log reader, as well as a set of tools for mocking the publisher pipeline. A few things have shifted around in the client/pipeline managers in order to make testing easier.