Fix and extend logging of light modules load errors #14706
Conversation
jsoriano
added
bug
review
Metricbeat
|
This is making many test to fail because they find errors in logs, I am adding |
|
what will happen to folks running tests outside docker? we need to think about that case too |
Logging-wise it would be the same. Regarding permissions, when running tests outside docker (and in systems with default umask != 0022 as most ubuntu distros) it is usual to require |
|
@jsoriano Seems like this PR is ready to go besides the conflict 😄 I saw this during triage party time. Could you take a look at this one again when you get a chance please? Thanks! |
|
@kaiyan-sheng good catch 😄 The original issue was solved in other way, but the fixes in logging may still be needed, I will take a look. |
|
Revisited, this would be ready for another review. |
|
There was a bug causing regular files in the |
jsoriano
removed
the
needs_backport
Two things are solved here: * Errors were being logged with logp.Error that doesn't actually log anything, use a local logger and its Errorf method instead. * Log errors also when listing modules for string representation. This was hiding errors, what was specially confusing when permissions are not correct during development and testing, now errors are logged if permissions are not correct. Some errors have been rephrased so logged errors start with uppercase, and "failed to" is not logged in all nested errors. (cherry picked from commit 10da237)
Two things are solved here: * Errors were being logged with logp.Error that doesn't actually log anything, use a local logger and its Errorf method instead. * Log errors also when listing modules for string representation. This was hiding errors, what was specially confusing when permissions are not correct during development and testing, now errors are logged if permissions are not correct. Some errors have been rephrased so logged errors start with uppercase, and "failed to" is not logged in all nested errors. (cherry picked from commit 10da237)
Two things are solved here:
logp.Errorthat doesn't actually log anything, use a local logger and itsErrorfmethod instead.This was hiding errors, what was specially confusing when permissions are not correct during development and testing, now errors like this one are logged if permissions are not correct:
Some errors have been rephrased so logged errors start with uppercase, and "failed to" is not logged in all nested errors.