Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict permissible regex for instance name in perfmon #14666

Merged
merged 4 commits into from
Nov 25, 2019
Merged

Restrict permissible regex for instance name in perfmon #14666

merged 4 commits into from
Nov 25, 2019

Conversation

narph
Copy link
Contributor

@narph narph commented Nov 20, 2019

Should fix #14273.

Previous regular expression will pick up the string in the last parentheses. We restricted this to the first set instead.
Added tests for the regular expressions.

@narph narph requested a review from a team as a code owner November 20, 2019 19:01
@narph narph self-assigned this Nov 20, 2019
@narph narph added [zube]: In Progress Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Nov 20, 2019
@narph narph mentioned this pull request Nov 20, 2019
Closed
@narph narph requested a review from jsoriano November 21, 2019 14:25
@narph narph merged commit 6280f83 into elastic:master Nov 25, 2019
@narph narph deleted the perfmon-regex-fix branch November 25, 2019 10:03
@narph narph added the needs_backport PR is waiting to be backported to other branches. label Jan 10, 2020
narph added a commit to narph/beats that referenced this pull request Jan 10, 2020
@narph
Restrict permissible regex for instance name in perfmon (elastic#14666)
389083c 
* modify regex

* Added pr id

* refactor unittest

(cherry picked from commit 6280f83)
@narph narph mentioned this pull request Jan 10, 2020
Merged
narph added a commit to narph/beats that referenced this pull request Jan 10, 2020
@narph
Restrict permissible regex for instance name in perfmon (elastic#14666)
a11942e 
* modify regex

* Added pr id

* refactor unittest

(cherry picked from commit 6280f83)
@narph narph mentioned this pull request Jan 10, 2020
Merged
narph added a commit that referenced this pull request Jan 10, 2020
@narph
Cherry-pick #14666 to 7.5: Restrict permissible regex for instance na…
9f50314 
…me in perfmon (#15466)

* Restrict permissible regex for instance name in perfmon  (#14666)

* modify regex

* Added pr id

* refactor unittest

(cherry picked from commit 6280f83)

* Fix changelog
narph added a commit that referenced this pull request Jan 10, 2020
@narph
Cherry-pick #14666 to 7.x: Restrict permissible regex for instance na…
2fff183 
…me in perfmon (#15464)

* Restrict permissible regex for instance name in perfmon  (#14666)

* modify regex

* Added pr id

* refactor unittest

(cherry picked from commit 6280f83)

* Fix changelog
@narph narph removed the needs_backport PR is waiting to be backported to other branches. label Jan 15, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@narph
Cherry-pick elastic#14666 to 7.5: Restrict permissible regex for inst…
40e873e 
…ance name in perfmon (elastic#15466)

* Restrict permissible regex for instance name in perfmon  (elastic#14666)

* modify regex

* Added pr id

* refactor unittest

(cherry picked from commit d1463bc)

* Fix changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@narph narph

Labels
Metricbeat Metricbeat Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metricbeat] Windows perfmon wildcard queries with multiple brackets show wrong instance name
4 participants
@narph @jsoriano @kaiyan-sheng @andresrc