Fixing node name to use DATA grok pattern
#14547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the node name field was being parsed using the `WORD` grok patterns, which does not allow for characters such as `-` in the node name. Such characters are acceptable in Elasticsearch node names, so this PR fixes the grok expression to try and parse the node name using the more-accepting `DATA` grok pattern.
jsoriano
approved these changes
Nov 15, 2019
|
jenkins, test this |
|
Travis CI is green. Jenkins CI failures are unrelated to this PR. Merging. |
This was referenced Nov 18, 2019
ycombinator
added a commit
that referenced
this pull request
Nov 19, 2019
* Fixing node name to use `DATA` grok pattern Previously, the node name field was being parsed using the `WORD` grok patterns, which does not allow for characters such as `-` in the node name. Such characters are acceptable in Elasticsearch node names, so this PR fixes the grok expression to try and parse the node name using the more-accepting `DATA` grok pattern. * Adding sample log entry * Adding CHANGELOG entry
ycombinator
added a commit
that referenced
this pull request
Nov 20, 2019
* Fixing node name to use `DATA` grok pattern (#14547) * Fixing node name to use `DATA` grok pattern Previously, the node name field was being parsed using the `WORD` grok patterns, which does not allow for characters such as `-` in the node name. Such characters are acceptable in Elasticsearch node names, so this PR fixes the grok expression to try and parse the node name using the more-accepting `DATA` grok pattern. * Adding sample log entry * Adding CHANGELOG entry * Fixing CHANGELOG
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…astic#14583) * Fixing node name to use `DATA` grok pattern (elastic#14547) * Fixing node name to use `DATA` grok pattern Previously, the node name field was being parsed using the `WORD` grok patterns, which does not allow for characters such as `-` in the node name. Such characters are acceptable in Elasticsearch node names, so this PR fixes the grok expression to try and parse the node name using the more-accepting `DATA` grok pattern. * Adding sample log entry * Adding CHANGELOG entry * Fixing CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
elasticsearch/slowlogfileset was parsing the node name field using theWORDgrok pattern, which does not allow for characters such as-. Such characters are acceptable in Elasticsearch node names, so this PR fixes the grok expression to try and parse the node name using the more-acceptingDATAgrok pattern.