[Docker logging driver] Shuffle around docker deps due to import path checking #14523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
exekias
approved these changes
Nov 14, 2019
kvch
approved these changes
Nov 15, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
… checking (elastic#14523) * shuffle around docker deps due to import path checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this is a tad weird. It appears that docker uses import path checking. This makes sense, since the docker engine is available at
docker/docker,docker/engineandmoby/moby. However, for reasons unknown to me, this didn't break the build until go 1.13. I can't find anything in the go change log for 1.13 about enforcing import path checking, so I'm not sure why this only broke now.So, this PR just migrates the dependencies from
docker/enginetodocker/docker, which is what the rest of the beats repo uses.